3437 geo json api file download

[JeremyFreiburger]

…for API page

Resolves #3437

Creates optional parameter for /attributes and /attributesWithLabels API calls for geojson. Set inline parameter default to false and to true for maps on Project Sidewalk API webpage.

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've added/updated comments for large or confusing blocks of code.

[misaugstad]

Your inlineCheck parameter isn't actually working! If I go to the URL http://localhost:9000/v2/access/attributes?inlineCheck=true, it still downloads a file instead of making it inline!

The other issue is that the URLs where you added the inlineCheck=true are actually the exact endpoints that we don't want to show inline! From the initial issue:

In Seattle, our dataset is now so large that the browser crashes when trying to render the full /attributesWithLabels endpoint in GeoJSON

And the URLs you added inlineCheck=true to are the ones for downloading the entire dataset. I'd like to just see you add those for the URLs where users click on the examples so that we can open up those small examples in a new tab inline!

[JeremyFreiburger]

Ready for review again! Files look good

[misaugstad]

The code doesn't seem to be compiling... First error I get is

[error] /opt/app/controllers/ProjectSidewalkAPIController.scala:190: reassignment to val
[error]       Future.successful(Ok.sendFile(content = attributesJsonFile, inline = inline = inline.getOrElse(false), onClose = () => attributesJsonFile.delete()))

I changed the inline = inline = inline.getOrElse(false) to just inline = inline.getOrElse(false). Then I got a new error:

[error] /opt/conf/routes:151: not enough arguments for method getAccessAttributesWithLabelsV2: (lat1: Option[Double], lng1: Option[Double], lat2: Option[Double], lng2: Option[Double], severity: Option[String], filetype: Option[String], inline: Option[Boolean])play.api.mvc.Action[play.api.mvc.AnyContent].
[error] Unspecified value parameter inline.

Is it possible that you didn't push your latest commit..?

[JeremyFreiburger]

Yes, it is very likely I forgot to add a file to the commit, I remember this exact error. I will fix this as soon as possible today.

[JeremyFreiburger]

Just committed changes, hopefully this time i've got it!

[misaugstad]

A couple small things:

1. In the examples on the API page, you added the inline parameter to the call that is for a CSV. It just gets ignored anyway, but it was added unnecessarily, so let's just remove it so that it isn't confusing.
2. Let's also remove the inline parameter from what users see when they click on the examples on the API page. Let's have the actual link use the inline param, but just don't show it here:
   

Otherwise, it looks good!

[JeremyFreiburger]

Just committed your last suggested changes.

[misaugstad]

Looks good, thanks @JeremyFreiburger!