Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds anchor links to API subsections #3459

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

kevinjxc
Copy link
Collaborator

@kevinjxc kevinjxc commented Jan 22, 2024

Resolves #3299
There were no anchor links for each API subsection before the addition of these anchor links. Additionally, CSS was added so that the anchor links directed users to the accurate portion of the subsection.

Before Video (File Too Large to Upload Directly)
https://drive.google.com/file/d/1pqih7p6HPmNFettPXhMOmSfsnCSv26SF/view?usp=sharing

After Video (File Too Large to Upload Directly)
https://drive.google.com/file/d/1a_ejcy8gjrGQJc21cqi_rNhqmZU0VbqB/view?usp=sharing

Things to check before submitting the PR

  • I've written a descriptive PR title.
  • I've included before/after screenshots above.

Remaining checklist items did not apply to this pull request.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjxc!

I made some edits so that the functionality was closer to that of the Labeling Guide. And I cleaned things up a bit to put the shared CSS into main.css, especially since I expect that we'll want to include these links elsewhere on the website in the future.

@misaugstad misaugstad merged commit 28c51d4 into develop Jan 22, 2024
@misaugstad misaugstad deleted the 3299-api-subsection-anchor-links branch January 22, 2024 20:40
@misaugstad misaugstad mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anchor links to API subsections
2 participants