-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Pedestrian Signal tags #3501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Webpage into 3240-audio-pedestrian-signal-tags
After further discussion in #3240, here's where we're at now... The following changes are made to the Pedestrian Signal tags:
So the full list of tags is now:
Before/After screenshots (if applicable) |
Looks great!
Sent from phone
…On Tue, Feb 27, 2024 at 5:34 PM Michael Saugstad ***@***.***> wrote:
After further discussion in #3240
<#3240>, here's
where we're at now...
The following changes are made to the Pedestrian Signal tags:
- Added "one button"
- Added "two buttons"
- Removed "has button" (turned all of those into "one button" so we
don't throw away all info)
- Added "hard to reach buttons"
- Hid "button waist height" (bc it is replaced by "hard to reach
buttons")
- Renamed "APS" to "tactile-audible buttons"
- Unhid "tactile-audible button" (formerly "APS")
- Added example images to all available tags for Ped Signal
So the full list of tags is now:
- one button
- two buttons
- hard to reach buttons
- tactile-audible buttons
Before/After screenshots (if applicable)
Before
Screenshot.from.2024-02-26.11-45-49.png (view on web)
<https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/32d7eece-4553-4a6c-b44e-261abd184a15>
After
Screenshot.from.2024-02-27.15-28-11.png (view on web)
<https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/e49fb25b-da94-4d77-a6fa-cb186c441394>
Screenshot.from.2024-02-27.15-28-12.png (view on web)
<https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/2a9034cd-38ee-4f67-83c3-a85519f018bc>
Screenshot.from.2024-02-27.15-28-14.png (view on web)
<https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/08757825-116a-4da2-a77a-57cbc2d163d6>
Screenshot.from.2024-02-27.15-28-17.png (view on web)
<https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/890623f9-4d3f-4fb9-9f61-6f6ecdbea9e0>
—
Reply to this email directly, view it on GitHub
<#3501 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAML55NLHCHO2UFXAA7JTV3YVZURJAVCNFSM6AAAAABD22IOX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXHEYTCNJSGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3240 (partially resolved)
NOTE: after discussion, these have been changed, see this comment below for up-to-date info on what was added in this PR.
The following changes are made to the Pedestrian Signal tags:
So the full list of tags is now:
Before/After screenshots (if applicable)
Before
After
Things to check before submitting the PR