Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Pedestrian Signal tags #3501

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Conversation

misaugstad
Copy link
Member

@misaugstad misaugstad commented Feb 26, 2024

#3240 (partially resolved)

NOTE: after discussion, these have been changed, see this comment below for up-to-date info on what was added in this PR.

The following changes are made to the Pedestrian Signal tags:

  • "APS" has been renamed to "tactile-audible button"
  • Added "hard to reach button"
  • Hide "button waist height" (bc it is replaced by "hard to reach button")
  • Unhides "tactile-audible button" (formerly "APS") in Chicago
  • Adds example images to all available tags for Ped Signal

So the full list of tags is now:

  • has button
  • hard to reach button
  • tactile-audible button (Chicago only)
Before/After screenshots (if applicable)

Before
Screenshot from 2024-02-26 11-45-49

After
Screenshot from 2024-02-26 11-46-07
Screenshot from 2024-02-26 11-46-11
Screenshot from 2024-02-26 11-46-17

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.

@misaugstad misaugstad self-assigned this Feb 26, 2024
@misaugstad
Copy link
Member Author

After further discussion in #3240, here's where we're at now...

The following changes are made to the Pedestrian Signal tags:

  • Added "one button"
  • Added "two buttons"
  • Removed "has button" (turned all of those into "one button" so we don't throw away all info)
  • Added "hard to reach buttons"
  • Hid "button waist height" (bc it is replaced by "hard to reach buttons")
  • Renamed "APS" to "tactile-audible buttons"
  • Unhid "tactile-audible button" (formerly "APS")
  • Added example images to all available tags for Ped Signal

So the full list of tags is now:

  • one button
  • two buttons
  • hard to reach buttons
  • tactile-audible buttons
Before/After screenshots (if applicable)

Before
Screenshot from 2024-02-26 11-45-49

After
Screenshot from 2024-02-27 15-28-11
Screenshot from 2024-02-27 15-28-12
Screenshot from 2024-02-27 15-28-14
Screenshot from 2024-02-27 15-28-17

@jonfroehlich
Copy link
Member

jonfroehlich commented Feb 28, 2024 via email

@misaugstad misaugstad merged commit 4435f56 into develop Feb 28, 2024
@misaugstad misaugstad deleted the 3240-audio-pedestrian-signal-tags branch February 28, 2024 01:00
@misaugstad misaugstad mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants