Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an admin version of Validate #3510

Merged
merged 13 commits into from
Mar 5, 2024
Merged

Adds an admin version of Validate #3510

merged 13 commits into from
Mar 5, 2024

Conversation

misaugstad
Copy link
Member

Resolves #3496

Adds Admin Validate, an admin version of the Validate page that shows additional information and lets admins filter for what labels they want to be validating. When an admin is signed in, they can find the page from the drop down menu in the navbar below the regular admin page.

Instead of the example images, the right sidebar will show who placed the label you're validating, who has validated this label in the past, and what the outcome of those validations were.

Using query parameters, you can choose which label type to validate, filter down to a list of users, and filter down to a list of neighborhoods to pull the labels you validate from. For each of these filters, you can specify either the ID number (labelTypeId, userId, regionId) or the actual name (e.g., "CurbRamp", "jonfroehlich", "Laurelhurst"). And all of them can be used in conjunction. I've added some instructions to the page for how to use the query parameters for the less technically savvy, and if any inputs don't match something in the database, I'm trying to return a reasonable error message!

Screenshots

A view of the navbar
Screenshot from 2024-03-04 16-32-12

A full view of the page where you can see the URL I used. I even mixed and matched one username and one userId! 😁
Screenshot from 2024-03-04 16-31-57

A closer look at the sidebar with the info
Screenshot from 2024-03-04 16-47-39

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

@misaugstad misaugstad self-assigned this Mar 5, 2024
@misaugstad misaugstad merged commit 7e52e5c into develop Mar 5, 2024
@misaugstad misaugstad deleted the 3496-admin-validate branch March 5, 2024 01:30
@misaugstad misaugstad mentioned this pull request Mar 5, 2024
@jonfroehlich
Copy link
Member

This is awesome!

Would it be possible to put the following in a information pop-up linked by an (i) icon or something? Just feels like it's a dump of information not relevant to key tasks (super helpful to know about but not necessary to burn screen real estate to show at all times? also clutters things)

image

@misaugstad
Copy link
Member Author

I agree that it looks bad, and that could definitely be done... I just don't think it's worth it to work on making it look nicer when this is already only for admins and we are about to completely redo the look of the Validate page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For admins, show other users who validated on validate page?
2 participants