Added variable height for Admin neighborhood completion histogram and… #3575
Conversation
… increased font size of names of neighborhoods
…Webpage into 3565-admin-neighborhood-completion-histogram-variable-height
|
@nschung28 there should definitely be screenshots for this! |
There was a problem hiding this comment.
I think that the y-direction is looking good! But I'm now seeing that we have a scroll in the x-direction in the cities that I tested, and that wasn't an issue before. Is it because of the increased font size or something? We should definitely get rid of the x-direction scrolling! Possibly it could help to orient the y-axis labels at a 45 degree angle?
| $.getJSON('/adminapi/neighborhoodCompletionRate', function (data) { | ||
| // Determine height of the chart based on size of data |
There was a problem hiding this comment.
A reminder to end comments with a period, as per style guide 🙃
There was a problem hiding this comment.
And instead of "size of data", it might be more clear to say "the number of neighborhoods"
There was a problem hiding this comment.
Sorry about that! I'll go back and fix this.
There was a problem hiding this comment.
I'll also take a look into the x-axis scrolling issue and get those changes pushed asap!
| $.getJSON('/adminapi/neighborhoodCompletionRate', function (data) { | ||
| // Determine height of the chart based on size of data | ||
| var chartHeight = data.length * 30; |
There was a problem hiding this comment.
Might as well just do var chartHeight = 150 + 30 * data.length;
…Webpage into 3565-admin-neighborhood-completion-histogram-variable-height
… to remove overflow on the x-axis, and edited comments to be more descriptive
… to remove overflow on the x-axis, and edited comments to be more descriptive
…eight' of https://github.com/ProjectSidewalk/SidewalkWebpage into 3565-admin-neighborhood-completion-histogram-variable-height
… to remove overflow on the x-axis, and edited comments to be more descriptive
|
Before (with 3 neighborhoods): After (with 3 neighborhoods): Before (with 1049 neighborhoods): After (with 1049 neighborhoods): 
Note that in the after with 1049 neighborhoods the first screenshot is the top of the chart, the second is the middle, and the third is the bottom. |
…Webpage into 3565-admin-neighborhood-completion-histogram-variable-height
misaugstad
deleted the
3565-admin-neighborhood-completion-histogram-variable-height
branch
Resolves #3565
Made neighborhood completion histogram height variable depending on the dataset and also increased the font size of the neighborhoods on the y-axis.
Testing instructions
Things to check before submitting the PR