Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent short gallery tags from taking up too much space #3637

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jsomeara
Copy link
Collaborator

Resolves #3636

Short gallery tags were not being displayed properly, and they were taking up too much space. This was fixed by removing the flex: 1 css property which was never necessary in the first place (I accidently added this in my first PR which fixed long gallery tags). I tested both short and long gallery tags this time.

Before/After screenshots (if applicable)

Before
image
After
image

Testing instructions
  1. Go to gallery
  2. Find a label with short tags
  3. Verify that the short tag is not filling up the whole space, as seen in the before screenshot
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've included before/after screenshots above.

@jsomeara jsomeara self-assigned this Aug 28, 2024
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!!

@misaugstad misaugstad merged commit 05dd996 into develop Aug 29, 2024
@misaugstad misaugstad deleted the 3636-short-gallery-tags branch August 29, 2024 17:16
@misaugstad misaugstad mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short Gallery tags aren't displayed correctly
2 participants