Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3580 new validate tooltips #3641

Merged
merged 13 commits into from
Aug 30, 2024
Merged

3580 new validate tooltips #3641

merged 13 commits into from
Aug 30, 2024

Conversation

misaugstad
Copy link
Member

Resolves #3580

Adds tooltips on the new Validate page for most buttons:

  • Tags: Using same examples from Explore context menu
  • Severity: Using same examples from Explore context menu
  • Disagree & Unsure reason buttons: I found new images for these and wrote some new text. But some text/images copies from the correct/incorrect examples on the main Validate page

Other small changes:

  • Adds severity examples for Crosswalk
  • Replaces the example image for the "very long crossing" tag with a better one
  • Fixes some issues when getting a second mission with a different label type, not everything was being reset properly before
  • Alll errors in console for not finding images should be gone on Explore page now. Everything that needs an image has one, and nothing that doesn't need an image is trying to request one anymore

I've included translations for anything that's shown on the Explore page as well, but I'll add translations to the entire Validate page soon (#3586) after I get another set of eyes on the text in all the tooltips on the live system.

Before/After screenshots (if applicable)

Before looks the same with no tooltips, here's the after!
Screenshot from 2024-08-30 11-07-13
Screenshot from 2024-08-30 11-08-36
Screenshot from 2024-08-30 11-10-24
Screenshot from 2024-08-30 11-09-23
Screenshot from 2024-08-30 11-09-59

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.

@misaugstad misaugstad self-assigned this Aug 30, 2024
@misaugstad misaugstad merged commit d6db06d into develop Aug 30, 2024
@misaugstad misaugstad deleted the 3580-new-validate-tooltips branch August 30, 2024 22:19
@misaugstad misaugstad mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Validate should have tooltips over tags and disagree buttons
1 participant