Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed quarterly Google Update for API to Weekly #3672

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aslassi777
Copy link
Collaborator

@aslassi777 aslassi777 commented Sep 29, 2024

Resolves #3620

Looked into Google Maps API potential update issues. Specifically, used beta channel in localhost to ensure that the small google maps (to the right of the street view) works as intended and does not require any updates to the code. Tested by setting the channel to beta and doing a few explore missions on my computer in localhost. Did not see any changes. Updated the api key to weekly now per @misaugstad request (only thing that was changed).

Related links:

https://developers.google.com/maps/documentation/javascript/releases
https://developers.google.com/maps/documentation/javascript/versions

Before/After screenshots (if applicable)

N/A

Testing instructions

N/A

Things to check before submitting the PR
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
  • I've tested on mobile (only needed for validation page).

@misaugstad
Copy link
Member

@aslassi777 The reason for the ticket is that Google is making this new "Camera" control the default over the previous "Zoom" control, so I'd like for us to switch over to the new control even if using the old control isn't breaking anything on the beta channel!

And in the PR template, if you replace the " " with an "x" instead of just adding an "x", it will render as checked checkboxes like this!

  • check!

@aslassi777
Copy link
Collaborator Author

aslassi777 commented Sep 30, 2024

thanks @misaugstad for clarification, will do! @misaugstad just to make sure, this is for the mini map on the right side of the explore/missions page correct? I'm looking at the controls for that map and it seems that the zoomControl is set to false (this might end up having to get removed). Maybe this is why it wasn't broken when I switched over to beta channel. It also seems that we have defaultUI set to false, which prohibits the new camera controls from being used in the default settings (when on beta channel) per the google website. I'll add in the new camera controls and see what changes...

Also, I'm just going to put some links here for my own reference:

Controls: https://developers.google.com/maps/documentation/javascript/controls
Default UI: https://developers.google.com/maps/documentation/javascript/controls#DefaultUI
Camera Controls Interface: https://developers.google.com/maps/documentation/javascript/reference/control#CameraControlOptions

@misaugstad
Copy link
Member

this is for the mini map on the right side of the explore/missions page correct

correct!

the zoomControl is set to false (this might end up having to get removed). Maybe this is why it wasn't broken when I switched over to beta channel. It also seems that we have defaultUI set to false, which prohibits the new camera controls from being used in the default settings (when on beta channel) per the google website. I'll add in the new camera controls and see what changes...

Yep, expected as much! I'm hoping that you can work through the documentation and the different types of control settings to figure out what exists now, what the recommended controls are in the future, and to set up the controls to work going forward using their suggested controls, hopefully as simply as possible!

@aslassi777
Copy link
Collaborator Author

@misaugstad sounds good will do! I'm going to check out #3676 for a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Maps API Test the new Camera control on your maps before the default changes in version 3.60
2 participants