Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for expanded view going out of view when current expanded card is clicked again #3684

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

LeeJoh22
Copy link
Collaborator

@LeeJoh22 LeeJoh22 commented Oct 7, 2024

Resolves #3674

Fixed bug that caused the expanded view of a card to go out of view in Gallery view when the currently expanded card is clicked on again.

Before:

You click once on the card you want the expanded view of to get the following display.

image

If you click on the same card again through the side bar in expanded view, the expanded view shifts up the page so it is out of view. The higher the index of the card on the current page, the more the expanded view shifts. Image 1 is card 2 on the page and image 2 is card 3 on the page.

image image
After:

You click once on the card you want the expanded view of to get the following display.

image

If you click on the currently expanded card again, the expanded view remains unaffected.

image
Testing instructions
  1. Start local instance
  2. Click into Gallery view
  3. Click on any card on the page to open expanded view
  4. Click on the currently expanded card in the left side bar. Its expanded view shouldn't move on the page.
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've included before/after screenshots above.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sleuthing, love the simple fix!

@misaugstad misaugstad merged commit 65ef8b7 into develop Oct 7, 2024
@misaugstad misaugstad deleted the 3674-Expanded-View-Moves-Out-Of-View-Bug-Fix branch October 7, 2024 17:25
@misaugstad misaugstad mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on already chosen card causes Expanded View to move out of view
2 participants