Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements 506 - Make admin map visualization interactive #526

Merged
merged 16 commits into from
Jun 16, 2017

Conversation

m-furman
Copy link
Collaborator

Resolves #506.

Currently storing all data locally in layers so that we don't have to re-request the JSON data every time the user selects/deselects a label. The labels can now be toggled on/off without significant delay.

@jonfroehlich
Copy link
Member

jonfroehlich commented Mar 11, 2017 via email

@manaswisaha
Copy link
Member

manaswisaha commented Mar 11, 2017 via email

@jonfroehlich
Copy link
Member

jonfroehlich commented Mar 12, 2017 via email

@manaswisaha
Copy link
Member

manaswisaha commented Mar 12, 2017 via email

@manaswisaha
Copy link
Member

manaswisaha commented Mar 12, 2017 via email

@jonfroehlich
Copy link
Member

jonfroehlich commented Mar 12, 2017 via email

@manaswisaha
Copy link
Member

The branch is buggy. It gives these errors when clicking the checkboxes:

image

Would have to see if these errors are present on the branch before merging the new updates from the latest version (v3.1.2) of develop.

@manaswisaha
Copy link
Member

manaswisaha commented Jun 7, 2017

@jetrax12 Could you remove the severity sliders for the labels for which we don't take severity values. And when you update it, paste a screenshot of it here.
You need to update the 506-create-map-layers branch. Its updated with your new changes.

@adevdash
Copy link
Collaborator

adevdash commented Jun 7, 2017

image

Removed sliders for occlusion and no sidewalk, the only ones which I think don't have severity. Some of the sample data I have for no sidewalk do indicate different severities, so I just ignored it and had it display all or none.

@manaswisaha
Copy link
Member

Could you move the 'Other' row up so that its after 'Surface Problem' row? It will be visually more symmetrical.

@adevdash
Copy link
Collaborator

image
With the rows exchanged.

@manaswisaha
Copy link
Member

Looks good! Thanks!

@manaswisaha manaswisaha merged commit a1f1df9 into develop Jun 16, 2017
@misaugstad misaugstad deleted the 506-create-map-layers branch March 25, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants