-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simplified surfaces and faster contouring #217
Conversation
@orso82 I didn't modify |
Also, once this PR is deemed ready to merge, this is a circumstance where we should run all the FUSE tests on it first. That will stress test the new contouring routines. |
To run the FUSE tests using your changes, just open a PR in FUSE on a branch with the same |
The IMAS 2.0 refactoring has been merged into this, which means both versions of |
@orso82 |
@orso82 All the FUSE regressions pass (ProjectTorreyPines/FUSE.jl#770) so I'll merge this unless you want to make the |
@bclyons12 this is great, although it's unclear to me what's the difference between Do we really need both? If we can't just have a single version, could you add a description to the docstring of |
@orso82 I cleaned up |
ig, jg = pts[argmax(pts_in_wall)] # this are the indices for the guess inside the wall | ||
rguess, zguess = r[ig], z[jg] | ||
RA, ZA = find_magnetic_axis(r, z, PSI_interpolant, psi_sign; rguess, zguess) | ||
if !isempty(wall_r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this @bclyons12 ! 👍
I wonder if we should add this logic directly to the find_magnetic_axis()
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would have to pass the wall to it then, so up to you. You could make a separate function that takes the wall as an argument and does this I suppose.
@orso82 If the FUSE tests pass (ProjectTorreyPines/FUSE.jl#770), I would like to merge this. |
All FUSE tests pass (ProjectTorreyPines/FUSE.jl#770) |
This creates a simplified, lighter-weight version of flux surfaces suited to some applications (e.g., FRESCO). It also uses the new IMASutils contouring where applicable.