Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting doesn't support raw SQL #27

Closed
rintaun opened this issue Dec 1, 2020 · 1 comment
Closed

Inserting doesn't support raw SQL #27

rintaun opened this issue Dec 1, 2020 · 1 comment
Labels
bug Something isn't working released

Comments

@rintaun
Copy link
Member

rintaun commented Dec 1, 2020

When inserting a single row, it's probably better to just use the values directly rather than using unnest... that would open up the opportunity to pass in SqlTokenType values, whereas unnest only supports primitive types.

apparently LH uses that in a couple places, so dbds probably needs to support it
@rintaun rintaun added the bug Something isn't working label Dec 1, 2020
@rintaun rintaun mentioned this issue Dec 1, 2020
Closed
@rintaun rintaun changed the title Don't use unnest when inserting a single row Inserting doesn't support raw SQL Dec 1, 2020
@kodiakhq kodiakhq bot closed this as completed in a8c94ca Dec 1, 2020
rintaun pushed a commit that referenced this issue Dec 1, 2020
@semantic-release-bot
chore(release): 1.2.2 [skip ci]
991f19a 
### [1.2.2](v1.2.1...v1.2.2) (2020-12-01)

### Bug Fixes

* allow insertion of non-uniform rows ([a4af9ab](a4af9ab)), closes [#28](#28)
* allow raw sql in inserts ([a8c94ca](a8c94ca)), closes [#27](#27)
@rintaun
Copy link
Member Author

rintaun commented Dec 1, 2020

🎉 This issue has been resolved in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot added a commit that referenced this issue Dec 14, 2020
@kodiakhq
chore(deps-dev): bump eslint-plugin-jsonc from 0.7.1 to 0.8.0 (#69)
c562d8c 
⚠️  Dependabot is rebasing this PR ⚠️
If you make any changes to it yourself then they will take precedence over the rebase.

Bumps eslint-plugin-jsonc from 0.7.1 to 0.8.0.

Release notes
Sourced from eslint-plugin-jsonc's releases.

v0.8.0
💥 Breaking Changes

#26 Deprecate jsonc/auto-config. use jsonc/auto rule instead.

✨ Enhancements
Core:

#26 Supports for Vue custom block.

New Rules:

#26 Added jsonc/auto rule.
#27 Added jsonc/key-name-casing rule.




Commits

f8bef3c 0.8.0
2cf2536 Supports for Vue custom block (#26)
9e11cd3 Add key-name-casing rule (#27)
40e6abd Update CI
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rintaun