Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MIT license file, keeping consistent with PromiseKit #7

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

lstomberg
Copy link
Contributor

Fixing #6 by adding a copy of the LICENSE from mxcl/PromiseKit. The only modification is the copyright year is set to '2018-present' since this file wasn't added until now. Let me know if this should be consistent with PromiseKit and instead say 2016-present.

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #7 into master will decrease coverage by 4.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #7     +/-   ##
========================================
- Coverage    53.1%   48.6%   -4.4%     
========================================
  Files           8      10      +2     
  Lines         313     278     -35     
  Branches       19       0     -19     
========================================
- Hits          166     135     -31     
+ Misses        146     143      -3     
+ Partials        1       0      -1
Impacted Files Coverage Δ
Sources/NSURLSession+AnyPromise.m 67.7% <0%> (-25.4%) ⬇️
Sources/NSURLSession+Promise.swift 25.5% <0%> (-2%) ⬇️
Sources/NSNotificationCenter+Promise.swift 100% <0%> (ø) ⬆️
Sources/NSObject+Promise.swift 100% <0%> (ø) ⬆️
Sources/afterlife.swift 100% <0%> (ø) ⬆️
Sources/NSURLSession+AnyPromise.h 100% <0%> (ø)
Sources/NSTask+AnyPromise.h 0% <0%> (ø)
Sources/Process+Promise.swift 45.9% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 364f0aa...f7574d6. Read the comment docs.

@mxcl mxcl merged commit 2fbb04a into PromiseKit:master Jun 6, 2018
@mxcl
Copy link
Member

mxcl commented Jun 6, 2018

Many thanks, I appreciate you doing this, I can only do so much multitasking day to day. Will push a version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants