'Cancel' for PromiseKit #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
========================================
Coverage ? 45.5%
========================================
Files ? 10
Lines ? 383
Branches ? 0
========================================
Hits ? 174
Misses ? 209
Partials ? 0
Continue to review full report at Codecov.
|
dougzilla32
force-pushed
the
CoreCancel
branch
from
ac76f1d
to
bfcb3f7
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
e9ef10c
to
9dcbbfc
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
d0dd9b7
to
0e947b3
Compare
dougzilla32
force-pushed
the
CoreCancel
branch
from
0e947b3
to
95cec59
Compare
…and doc updates The cancellable 'when' methods must be named 'cancellableWhen' due to a compiler bug. The compiler bug (described on line 330 of 'when.swift') causes a conflict between the non-cancellable 'when' functions and the cancellable 'when' functions. Fix 'isCancelled' on URLSessionTask to properly report the cancelled state.
|
Could we add this pull request to PromiseKit V7 Alpha? I'm ready with all the code to make the cancellable extensions work with PromiseKit V7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the diffs for option 1 of Proposal for PromiseKit cancellation support #896. With option 1 the new cancellation code is included with CorePromise.
There repositories involved with the pull request for option 1 are: