Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media links when renaming records. #103

Merged

Conversation

DavidSouther
Copy link
Collaborator

Closes #100

@stanparker
Copy link
Collaborator

Hmm...... now when renaming a record it adds new video links rather than replaces the old ones.

And the extra videos still exist after refresh.

<div flex-gt-md="25" layout="column" layout-md="row" layout-sm="row" class="layout-sm-row layout-md-row layout-column flex-gt-md-25"><!-- ngRepeat: video in state.record.videos --><div flex-md="50" ng-repeat="video in state.record.videos" class="ng-scope flex-md-50"><video controls="controls" class="ng-binding"><source ng-src="/images/courtney_2abcdefe/courtney002.mp4" type="video/mp4" src="/images/courtney_2abcdefe/courtney002.mp4">Can't play video: {
  "path": "courtney_2abcdefe/courtney002.mp4"
}</video></div><!-- end ngRepeat: video in state.record.videos --><div flex-md="50" ng-repeat="video in state.record.videos" class="ng-scope flex-md-50"><video controls="controls" class="ng-binding"><source ng-src="/images/courtney_2abcdefeabc/courtney002.mp4" type="video/mp4" src="/images/courtney_2abcdefeabc/courtney002.mp4">Can't play video: {
  "path": "courtney_2abcdefeabc/courtney002.mp4"
}</video></div><!-- end ngRepeat: video in state.record.videos --><div flex-md="50" ng-repeat="video in state.record.videos" class="ng-scope flex-md-50"><video controls="controls" class="ng-binding"><source ng-src="/images/courtney_2/courtney002.mp4" type="video/mp4" src="/images/courtney_2/courtney002.mp4">Can't play video: {
  "path": "courtney_2/courtney002.mp4"
}</video></div><!-- end ngRepeat: video in state.record.videos --><div flex-md="50" ng-repeat="video in state.record.videos" class="ng-scope flex-md-50"><video controls="controls" class="ng-binding"><source ng-src="/images/courtney_2abc/courtney002.mp4" type="video/mp4" src="/images/courtney_2abc/courtney002.mp4">Can't play video: {
  "path": "courtney_2abc/courtney002.mp4"
}</video></div><!-- end ngRepeat: video in state.record.videos --><div flex-md="50" ng-repeat="video in state.record.videos" class="ng-scope flex-md-50"><video controls="controls" class="ng-binding"><source ng-src="/images/courtney_2abcabc/courtney002.mp4" type="video/mp4" src="/images/courtney_2abcabc/courtney002.mp4">Can't play video: {
  "path": "courtney_2abcabc/courtney002.mp4"
}</video></div><!-- end ngRepeat: video in state.record.videos --><div flex-md="50" class="flex-md-50"><md-input-container style="width: 15em; height: auto;" class="md-input-has-placeholder"><label for="input_5">Notes</label><textarea ng-model="state.record.notes" placeholder="Notes" class="ng-pristine ng-untouched ng-valid md-input ng-empty" id="input_5" rows="1" aria-invalid="false" style="height: 32px;"></textarea><div class="md-errors-spacer"></div></md-input-container></div></div>

@stanparker
Copy link
Collaborator

To replicate:

  1. Navigate to server
  2. Create new record with label "Video Test Rename"
  3. Add a video
  4. Collapse the record
  5. Open it
  6. Click Edit
  7. Change the label to "Video Test Remix"
  8. Click Done
  9. Collapse Record
  10. Open it to see the video and a blank video player connected to nothing.

@stanparker
Copy link
Collaborator

@stanparker
Copy link
Collaborator

not quite ready yet

@stanparker
Copy link
Collaborator

Tested OK. Good to merge?

@DavidSouther
Copy link
Collaborator Author

Yep

On Mon, Apr 11, 2016, 11:10 PM Stan Parker notifications@github.com wrote:

Tested OK. Good to merge?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#103 (comment)

@DavidSouther DavidSouther merged commit 8bb564d into PronghornDigital:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants