-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit armor headers in sorted order #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
For completeness, in case this is something you care about, note that key serialization for entities with multiple user IDs is also not deterministic: Line 780 in 5521d83
SerializePrivate ).
|
We don't call that code in hockeypuck AFAICT. We have a standard sort order that gets applied to packet sequences before display in the index view, which we can also apply to armored output. |
…499) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ProtonMail/go-crypto](https://github.com/ProtonMail/go-crypto) | require | patch | `v1.1.3` -> `v1.1.4` | --- ### Release Notes <details> <summary>ProtonMail/go-crypto (github.com/ProtonMail/go-crypto)</summary> ### [`v1.1.4`](https://github.com/ProtonMail/go-crypto/releases/tag/v1.1.4) [Compare Source](ProtonMail/go-crypto@v1.1.3...v1.1.4) #### What's Changed - Emit armor headers in sorted order by [@​andrewgdotcom](https://github.com/andrewgdotcom) in ProtonMail/go-crypto#255 - Reduce memory usage when AEAD en/decrypting large messages by [@​twiss](https://github.com/twiss) in ProtonMail/go-crypto#259 - Update artifact actions to v4 by [@​twiss](https://github.com/twiss) in ProtonMail/go-crypto#260 **Full Changelog**: ProtonMail/go-crypto@v1.1.3...v1.1.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6499 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
closes #254