Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golint vet errcheck on ProtonMail fork #32

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Golint vet errcheck on ProtonMail fork #32

wants to merge 15 commits into from

Commits on Aug 30, 2019

  1. Lint, errcheck, vet, deadcode on ProtonMail-provided code. 

    Halfway through

Halfway through

Finished first pass

Solving tests.

Relaxing a bit on useless comments, but frowning.

Fix comment

Linted openpgp/packet, at least some of it

Reverting ID -> Id

Reverting Fingerprint -> FingerPrint

Solving tests

Relaxing on some useless comment and reverting Fingerprint -> FingerPrint

Missing parenthesis

Corrected exported object comments globally
    tal-botvinnik committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    12366c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. openpgp: Repaired some shadowed errors, discovered inactive test that… 

    … does not pass
    zugzwang committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    f3b8034 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2019

  1. Fixed some shadowed declarations and err checking

    zugzwang committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    263b967 View commit details
    Browse the repository at this point in the history

  2. Update openpgp/internal/algorithm/cipher.go 

    Co-Authored-By: Daniel Huigens <d.huigens@protonmail.com>
    @zugzwang @twiss
    zugzwang and twiss authored Nov 2, 2019
    Configuration menu
    Copy the full SHA
    f0dec49 View commit details
    Browse the repository at this point in the history

  3. Reverting end-to-end-test in favor of ProtonMail#37 and addressing tw… 

    …iss comments
    zugzwang committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    e4c9ff9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'golint-vet-errcheck-protonmail-fork' of github.com:zugz… 

    …wang/crypto into golint-vet-errcheck-protonmail-fork
    zugzwang committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    1362900 View commit details
    Browse the repository at this point in the history

  5. Remove unnecesary conversion

    zugzwang committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    dd35a8d View commit details
    Browse the repository at this point in the history

  6. Small style improvements

    zugzwang committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    1694ebe View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. Merge branch 'master' into golint-vet-errcheck-protonmail-fork

    zugzwang committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    080235a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Solve conflicts

    zugzwang committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    bb412a6 View commit details
    Browse the repository at this point in the history

  2. Remove function reference from bcrypt comments

    zugzwang committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e363b82 View commit details
    Browse the repository at this point in the history

  3. Remove non-PM comment correction

    zugzwang committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    98fd4af View commit details
    Browse the repository at this point in the history

  4. Remove non-PM comment corrections

    zugzwang committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a0b2e01 View commit details
    Browse the repository at this point in the history

  5. Remove non-PM comment corrections

    zugzwang committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    42e6669 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Merge branch 'master' into golint-vet-errcheck-protonmail-fork

    zugzwang committed May 2, 2020
    Configuration menu
    Copy the full SHA
    fe63ad0 View commit details
    Browse the repository at this point in the history