Skip to content

Commit

Permalink
fix hostname segment regex
Browse files Browse the repository at this point in the history
  • Loading branch information
@wesinator @XavierProton
wesinator authored and XavierProton committed Sep 11, 2024
1 parent 06599f9 commit dda4fdb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proton/session/transports/utils/dns.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class DNSParser:
# - it has a minimum of 1 character and maximum of 63,
# - it only contains alphanumeric characters or the hyphen but
# - it does not start or end with a hyphen.
_VALID_HOSTNAME_SEGMENT = re.compile("(?!-)[A-Z\d-]{1,63}(?<!-)$", re.IGNORECASE)
_VALID_HOSTNAME_SEGMENT = re.compile(r"(?!-)[A-Z\d-]{1,63}(?<!-)$", re.IGNORECASE)

# type definitions
IPvxAddress = typing.Union[ipaddress.IPv4Address, ipaddress.IPv6Address]
Expand Down

2 comments on commit dda4fdb

@wesinator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierProton I'm confused - how was this committed but my PR wasn't merged?! Is it ok to close my PR?

@XavierProton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !
We have our own git repo internal containing code not yet released to production.
So I have manually merged your PR in out internal repo using git format-patches / apply-patches (it helps preserving the commit author).
However, the downside of that is it doesn't reflect the status on the PR, even if this is technically merged...
BTW, thank you for you contribution.

Please sign in to comment.