Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Network retrieval refactor #28081

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[Fix] Network retrieval refactor #28081

merged 4 commits into from
Jun 12, 2024

Conversation

evan-schott
Copy link
Contributor

@evan-schott evan-schott commented Jun 11, 2024 •
edited
Loading

Resolves #27977 and #27982.

Details:

  • Modularizes network retrievals. This way we are not maintaining two separate components for network retrievals, as previously we had both leo query and retriever.
  • Previously network requests yielding responses like Too Many Requests! Wait for 355256s were being erroneously inserted into the .aleo/registry cache of network dependencies. This PR ensures that all fetched aleo programs are valid programs.

@evan-schott evan-schott requested a review from d0cd June 11, 2024 21:40
d0cd
d0cd requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor questions.
It would be helpful to note in the description how the Too many requests error is resolved by this PR.

errors/src/errors/utils/util_errors.rs Outdated Show resolved Hide resolved
utils/retriever/src/retriever/mod.rs Show resolved Hide resolved
@evan-schott evan-schott requested a review from d0cd June 11, 2024 23:41
d0cd
d0cd approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit b61e2b4 into mainnet Jun 12, 2024
13 checks passed
@d0cd d0cd deleted the fix/too-many-reqs branch June 12, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Dependency retrieval
2 participants
@evan-schott @d0cd