Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-leo files to be in src folder #28322

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

ungaro
Copy link
Contributor

@ungaro ungaro commented Aug 14, 2024

Motivation

I use macOS X, and when I try to copy a file from inside the 'src' folder or simply visit the folder, macOS X creates '.DS_Store' files. When those files are created, Leo suddenly stops building. This is confusing for both newcomers and experienced programmers (it happened to me when my project suddenly stopped building for no apparent reason; the reason was macOS X creating a '.DS_Store' file inside the 'src' folder).

Test Plan

put any non leo file inside the src folder.

@ungaro
Copy link
Contributor Author

ungaro commented Aug 14, 2024

would love to get your feedback on this. @d0cd

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 245790f into ProvableHQ:mainnet Aug 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants