Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require comma separators (and nothing else) between struct members. #28381

Open
wants to merge 1 commit into
base: mainnet
Choose a base branch
from

Conversation

mikebenfield
Copy link
Collaborator

Fixes #28377, #28379

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor nits, otherwise the PR looks good!

@@ -0,0 +1,14 @@
/*
namespace: Parse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Append _fail to the file name of this test case as it is expected to fail.

@@ -0,0 +1,19 @@
/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Append _fail to the name of this test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The parsing of struct expressions, still allows both semicolons and commas as separators of components.
2 participants