Clean up dependencies. #28382
Clean up dependencies. #28382
Conversation
|
I doubt it reduces build times generally. Maybe in some weird cases where some crates were getting redundantly built multiple times? Not sure. IMO the main advantage is just keeping the versions and feature flags in one place. We bump the version of Leo or a dependency, we don't have to search across a ton of different Cargo.toml files to make changes. |
mikebenfield
force-pushed
the
dependencies
branch
from
d571cec
to
c03ba8b
Compare
|
|
||
| [dependencies.indexmap] | ||
| version = "1.9" | ||
| features = [ "serde-1" ] |
There was a problem hiding this comment.
Does the workspace dependency for indexmap need the serde-1 feature?
There was a problem hiding this comment.
My understanding from reading indexmap docs is that serde-1 is sort of deprecated now, and instead we're supposed to use serde.
These release notes mention serde-1 being removed (although for a later version than we're using)
https://github.com/indexmap-rs/indexmap/blob/master/RELEASES.md
Remove unused deps. Use workspace deps where appropriate.
mikebenfield
force-pushed
the
dependencies
branch
from
c03ba8b
to
c61b0a8
Compare
Remove unused deps. Use workspace deps where appropriate.