Use evaluate_function for CallStack::PackageRun; Sample response for CallStack::CheckDeployment #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
commented
Dec 5, 2023
d0cd
approved these changes
Dec 7, 2023
| @@ -182,4 +172,46 @@ impl<N: Network> Stack<N> { | |||
| // Return the plaintext. | |||
| Ok(plaintext) | |||
| } | |||
|
|
|||
| /// Returns a future for the given TODO. | |||
There was a problem hiding this comment.
Should the TODO be swapped out?
| ExternalRecord(locator) => { | ||
| // Retrieve the external stack. | ||
| let stack = substack.get_external_stack(locator.program_id())?; | ||
| // Sample the input. |
There was a problem hiding this comment.
Suggested change
| // Sample the input. | |
| // Sample the output. |
| @@ -83,6 +84,14 @@ pub trait StackProgram<N: Network> { | |||
|
|
|||
| /// Returns the expected number of calls for the given function name. | |||
| fn get_number_of_calls(&self, function_name: &Identifier<N>) -> Result<usize>; | |||
|
|
|||
| /// Samples a value for the given value_type | |||
There was a problem hiding this comment.
Suggested change
| /// Samples a value for the given value_type | |
| /// Samples a value for the given value_type. |
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| use super::*; | |||
| use console::program::{Argument, FinalizeType}; | |||
| pub use console::program::{Argument, FinalizeType}; | |||
There was a problem hiding this comment.
Nit: You can move the use here and in sample.rs to the module above. It'll let you get rid of the pub
vicsn
force-pushed
the
sample_response_checkdeployment
branch
from
7cba76f to
5b68ab6
Compare
|
Did another walk through the code, running on a local devnet and deploying and executing max nested programs succeeds. |
howardwu
reviewed
Dec 27, 2023
Signed-off-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
howardwu
reviewed
Dec 27, 2023
Comment on lines
295
to
300
| ExternalRecord(locator) => { | ||
| // Retrieve the external stack. | ||
| let stack = substack.get_external_stack(locator.program_id())?; | ||
| // Sample the output. | ||
| stack.sample_value(&address, &Record(*locator.resource()), rng) | ||
| } |
There was a problem hiding this comment.
Why not move this case directly into the impl of fn sample_value?
howardwu
reviewed
Dec 27, 2023
|
|
||
| // Retrieve the output operands. | ||
| let output_operands = | ||
| &function.outputs().iter().map(|output| output.operand()).collect::<Vec<_>>(); |
There was a problem hiding this comment.
Blind code copy pasta 53c69a8
howardwu
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we
evaluate_functionduring deployment, we risk hitting false positive failed constraints on our random assignment.So instead, this PR proposes to sample a response. After sampling, construction of Response is handled the same way evaluate_function.
Test Plan
In the future we will test a wider range of programs.
Related PRs
https://github.com/AleoHQ/snarkVM/pull/2176
https://github.com/AleoHQ/snarkVM/pull/2224
https://github.com/AleoHQ/snarkVM/pull/2226