Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopping a queue should delete all pending messages immediately #146

Closed
regevbr opened this issue Aug 6, 2023 · 0 comments · Fixed by #147
Closed

Stopping a queue should delete all pending messages immediately #146

regevbr opened this issue Aug 6, 2023 · 0 comments · Fixed by #147
Assignees
@regevbr
Labels
bug Something isn't working

Comments

@regevbr
Copy link
Contributor

regevbr commented Aug 6, 2023

Expected Behavior

When stopped, we should delete immediately all pending messages to be deleted

Current Behavior

The pending for deletion messages will be deleted when the deletion timeout occurs (and it does not delay the shutdown)

Possible Solution

Delete all pending messages after there are no more messages in flight.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Node version:
@regevbr regevbr added the bug Something isn't working label Aug 6, 2023
@regevbr regevbr self-assigned this Aug 6, 2023
@regevbr regevbr changed the title Stopping a queue should delete all pending messages immidieatly Stopping a queue should delete all pending messages immediately Aug 6, 2023
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
fix: Stopping a queue should delete all pending messages immediately #…
e71360b 
…146
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
fix: Stopping a queue should delete all pending messages immediately #…
9faeb5b 
…146
@regevbr regevbr mentioned this issue Aug 6, 2023
Merged
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
fix: Stopping a queue should delete all pending messages immediately #…
fd8c733 
…146
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
fix: Stopping a queue should delete all pending messages immediately #…
16b93ab 
…146 (#147)
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
fix: Stopping a queue should delete all pending messages immediately #…
adecde5 
…146
regevbr added a commit that referenced this issue Aug 6, 2023
@regevbr
publish: fix: Stopping a queue should delete all pending messages imm…
48265f1 
…ediately #146

generated from commit adecde5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regevbr regevbr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Stopping a queue should delete all pending messages immediately #146 PruvoNet/squiss-ts
1 participant
@regevbr