Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HandleSpawnBoss #2808

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Update HandleSpawnBoss #2808

merged 1 commit into from
Nov 10, 2022

Conversation

sgkoishi
Copy link
Contributor

@sgkoishi sgkoishi commented Nov 6, 2022

Apply permission restriction to Mechdusa, Deerclops, and slime pet

Copy link
Member

@hakusaro hakusaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but can you update the changelog?


if (bosses.Contains(thingType) && !args.Player.HasPermission(Permissions.summonboss))
var isKnownBoss = thingType > 0 && thingType < Main.maxNPCTypes && NPCID.Sets.MPAllowedEnemies[thingType];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Terraria 1.4.4.7:

public static bool[] MPAllowedEnemies = Factory.CreateBoolSet(4, 13, 50, 126, 125, 134, 127, 128, 131, 129, 130, 222, 245, 266, 370, 657, 668);

For context; original was:

private static readonly int[] bosses = { 4, 13, 50, 125, 126, 134, 127, 128, 131, 129, 130, 222, 245, 266, 370, 657 };

Apply permission restriction to Mechdusa, Deerclops, and slime pet
@sgkoishi sgkoishi requested a review from hakusaro November 7, 2022 19:47
@hakusaro hakusaro merged commit ea6a128 into Pryaxis:general-devel Nov 10, 2022
@sgkoishi sgkoishi deleted the pr2808 branch November 10, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants