Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Dockerfile #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add a Dockerfile #12

wants to merge 7 commits into from

Conversation

zoobab
Copy link

@zoobab zoobab commented Dec 17, 2018

add a Dockerfile

@Pryz
Copy link
Owner

Pryz commented Dec 17, 2018

Hey @zoobab,

Thanks for you PR. How do you plan to use this Dockerfile ?

I would prefer having the "build" part in the Makefile and just use a minimal OS for the Docker image. Like a FROM scratch or something. But all depend on how you are planning to use this Dockerfile :)

@zoobab
Copy link
Author

zoobab commented Dec 18, 2018

The goal is to have a way to build a release in a pretty reproductible way.

Right now, I am building a binary for Linux, tell me if I need to add some steps to cross-compile binaries for other platforms.

Github has a crappy way to make a binary releases (upload a file from the dev laptop). So at least if 2 people can run the same ./build.sh and obtain the same md5sum of the output binaries, I am already happy.

@zoobab
Copy link
Author

zoobab commented Dec 18, 2018

Tell me if I need to cross-compile for other platforms (darwin_amd64, windows_amd64), or even ARM...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants