improved ca path finding

.gitignore

@@ -20,4 +20,5 @@ build-aux
 config.log
 config.status
 configure
-cookie.txt
+cookie.txt
+ntuget

CMakeLists.txt

@@ -5,7 +5,7 @@ PROJECT(ntuget)
 SET(CMAKE_C_STANDARD 17)
 SET(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/CMake)
 
-INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/include ${CMAKE_SOURCE_DIR}/_dep/include)
+INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/include)
 
 FIND_PACKAGE(Curl REQUIRED)
 INCLUDE_DIRECTORIES(${CURL_INCLUDE_DIR})
@@ -23,9 +23,3 @@ ELSEIF(CMAKE_BUILD_TYPE STREQUAL "Release")
     TARGET_COMPILE_OPTIONS(ntuget PRIVATE -O2 -DNDEBUG)
     TARGET_LINK_OPTIONS(ntuget PRIVATE -s)
 ENDIF()
-
-ADD_CUSTOM_COMMAND(TARGET ntuget POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E copy_if_different
-    ${CMAKE_SOURCE_DIR}/curl-ca-bundle.crt
-    $<TARGET_FILE_DIR:ntuget>
-)

Makefile.am

@@ -5,6 +5,7 @@ CMAKE_DIST = \
 
 EXTRA_DIST = \
     $(CMAKE_DIST) \
+    CMakeLists.txt \
     Dockerfile \
     .dockerignore
 
@@ -13,6 +14,4 @@ SUBDIRS = \
 
 DIST_SUBDIRS = \
     $(SUBDIRS) \
-    include \
-    test \
-    docs
+    include

configure.ac

@@ -1,6 +1,6 @@
 AC_PREREQ([2.71])
 
-AC_INIT([ntuget], [-])
+AC_INIT([ntuget], [0.1.0])
 
 AC_CONFIG_SRCDIR([src/ntuget.c])
 AC_CONFIG_FILES([Makefile include/Makefile src/Makefile])

include/config.h

@@ -5,4 +5,10 @@
 #define SAML_URL "https://cool.ntu.edu.tw/login/saml"
 #define API_BASE_URL "https://cool.ntu.edu.tw/api/v1"
 
+#if defined(__unix__) || defined(__linux__) || defined(__APPLE__)
+#define SYSTEM_CA_PATH "/etc/ssl/certs/ca-certificates.crt"
+#else
+#define CA_FILE_NAME "ca-bundle.crt"
+#endif
+
 #endif

include/request.h

@@ -5,12 +5,15 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
+
+#if defined(__unix__) || defined(__linux__) || defined(__APPLE__)
+#include <sys/stat.h>
+#endif
+
 #include <curl/curl.h>
 #include "config.h"
 #include "utils.h"
 
-#define CA_FILE_NAME "curl-ca-bundle.crt"
-
 typedef struct
 {
     long status_code;

src/request.c

@@ -37,15 +37,33 @@ static size_t header_callback(char *buffer, size_t size, size_t nitems, void *us
     return total_size;
 }
 
+inline static char *get_certificate_path() {
+#if defined(__unix__) || defined(__linux__) || defined(__APPLE__)
+    struct stat buffer;
+    if (stat(SYSTEM_CA_PATH, &buffer) == 0) {
+        return strdup(SYSTEM_CA_PATH);
+    }
+    return NULL;
+#else
+    const char *exePath = executable_directory();
+    size_t len = strlen(exePath) + strlen(CA_FILE_NAME) + 1;
+    char *crt_dir = malloc(len * sizeof(char));
+    if (!crt_dir) {
+        free((void *)exePath);
+        return NULL;
+    }
+    snprintf(crt_dir, len, "%s%s", exePath, CA_FILE_NAME);
+    free((void *)exePath);
+    return crt_dir;
+#endif
+}
+
 RequestResponse *request_get(RequestOptions opt)
 {
     CURL *curl = curl_easy_init();
     RequestResponse *response = request_response_init();
 
-    const char *exePath = executable_directory();
-    size_t len = strlen(exePath) + strlen(CA_FILE_NAME) + 1;
-    char *crt_dir = malloc(len * sizeof(char));
-    snprintf(crt_dir, len, "%s%s", exePath, CA_FILE_NAME);
+    const char *crt_dir = get_certificate_path();
 
     if (curl)
     {
@@ -106,7 +124,6 @@ RequestResponse *request_get(RequestOptions opt)
     if (opt.verbose)
         printf("****************************************\n");
 
-    free((void *)exePath);
     free((void *)crt_dir);
     curl_easy_cleanup(curl);
 
@@ -118,10 +135,7 @@ RequestResponse *request_post(RequestOptions opt)
     CURL *curl = curl_easy_init();
     RequestResponse *response = request_response_init();
 
-    const char *exePath = executable_directory();
-    size_t len = strlen(exePath) + strlen(CA_FILE_NAME) + 1;
-    char *crt_dir = malloc(len * sizeof(char));
-    snprintf(crt_dir, len, "%s%s", exePath, CA_FILE_NAME);
+    const char *crt_dir = get_certificate_path();
 
     if (curl)
     {
@@ -186,7 +200,6 @@ RequestResponse *request_post(RequestOptions opt)
     if (opt.verbose)
         printf("****************************************\n");
 
-    free((void *)exePath);
     free((void *)crt_dir);
     curl_easy_cleanup(curl);