Merge pull request #423 from PubMatic-OpenWrap/UOE-5788

Uoe 5788
PubMatic-OpenWrap · Nov 24, 2020 · 073f2a7 · 073f2a7
2 parents bb00c5c + 0cd334a
commit 073f2a7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/modules/id5IdSystem.js b/modules/id5IdSystem.js
@@ -61,9 +61,11 @@ export const id5IdSubmodule = {
  if (!hasRequiredParams(configParams)) {
  return undefined;
  }
- if (!configParams || typeof parseInt(configParams.partner) !== 'number') {
+ //This check is redundant. moving it to the 'hasRequiredParams function instead' - UOE-5788
+ /*if (!configParams || typeof parseInt(configParams.partner) !== 'number') {
  utils.logError(`User ID - ID5 submodule requires partner to be defined as a number`);
- }
+ return undefined;
+ }*/
  configParams.partner = parseInt(configParams.partner)
  const hasGdpr = (consentData && typeof consentData.gdprApplies === 'boolean' && consentData.gdprApplies) ? 1 : 0;
  const gdprConsentString = hasGdpr ? consentData.consentString : '';
@@ -125,8 +127,8 @@ export const id5IdSubmodule = {
 };
 
 function hasRequiredParams(configParams) {
- if (!configParams || typeof configParams.partner !== 'number') {
- utils.logError(`User ID - ID5 submodule requires partner to be defined as a number`);
+ if (!configParams || typeof parseInt(configParams.partner) !== 'number' || isNaN(parseInt(configParams.partner)))  {
+ utils.logError(`User ID - ID5 submodule requires partner to be defined as a number - Current value received: ` + configParams.partner);
  return false;
  }
  return true;