Skip to content

Commit

Permalink
Prebid Upgrade to 4.25 (#451)
Browse files Browse the repository at this point in the history
* Smaato: Add userIds to BidRequest (#5927)

* Mediasquare: add native and video support (#5823)

* Mediasquare: Add support for uspConsent + schain userIds support. Plus enhance userSync

* fix iframeEnabled and pixelEnabled + suggested shortand statement

* mediasquare bidder: add metrics to onBidWon Event

* mediasquare bidder: fix getUserSyncs

* MediaSquare: add native and video support

* 33Across: Added Video Support (#5884)

* check gdpr in buildRequest

* User sync based on whether gdpr applies or not

* check if consent data exists during user sync

* split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable

* contribute viewability to ttxRequest

* update tests

* remove window mock from tests

* use local variables

* introduce ServerRequestBuilder

* add withOptions() method to ServerRequestBuilder

* add semicolons

* sync up package-lock.json with upstream/master

* stub window.top in tests

* introduce getTopWindowSize() for test purpose

* reformat code

* add withSite() method to TtxRequestBuilder

add withSite() method to TtxRequestBuilder

* add isIframe() and _isViewabilityMeasurable()

* handle NON_MEASURABLE viewability in nested iframes

* consider page visibility, stub utils functions getWindowTop() and getWindowSelf()

* contribute viewability as 0 for inactive tab

* add prebidjs version to ttx request

* send caller as an array

* send viewability as non measurable when unable to locate target HTMLElement, add warning message

* fix JSDoc in utils.js

* introduce mapAdSlotPathToElementId()

* introduce getAdSlotHTMLElement(), add logging

* introduce mapAdSlotPathToElementId()

* update logging in ad unit path to element id mapping

* rephrase logging, fix tests

* update adapter documentation

* remove excessive logging

* improve logging

* revert change

* fix return of _mapAdUnitPathToElementId()

* improve logging of _mapAdUnitPathToElementId()

* do not use Array.find()

* return id once element is found

* return id once element is found

* let -> const

* Removing killswitch behavior for GDPR

* Updated comments to reflect current gdpr logic

* URI encode consent string

* Updated example site ID to help Prebid team e2e test our adapter

* send page url in ortb

* Removed redundant pageUrl default

* Restored package-log.json that mirrors prebid's repo

* Sending USP string during buildRequest

* Adding USP consent data to user sync

* add unit test for syncing without bidrequest

* Changed to uspConsent to make the connatation consistent

* Resetting adapter state in adapter after user sync rather than exposing it.

* removed console log

* Adding schain info

* remove setting empty format ext

* better tests invalid values

* removing validation of schain

* Fixed lint errors

* First cut for bidfloors support

* fixed where getFloors is read

* fixed merge conflicts

* support the guid in the api endpoint

* Reformat + validation updates

* refactor banner to conform to mediaType format

* Building video ORTB

* code review changes for better refactor

* Building video ORTB

* Interpret video response

* Updated documentation

* Updated supported mediatypes

* Added bidfloors

* Adding support bidder specific overrides

* only validate startdelay when instream

* fixed incorrect params for instream

* Removed usage of an actual GUID for safety.

* Added mimes and protocols as required

* placement is +ve int

* fix for sizes + valid sample GUID

Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com>
Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com>
Co-authored-by: Gleb Glushtsov <gleb.glushtsov@gmail.com>
Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-29-nyc.internal.33across.com>
Co-authored-by: Aparna Hegde <ahegde@admins-MacBook-Pro.local>
Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-137-nyc.internal.33across.com>
Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-96-nyc.internal.33across.com>
Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local>
Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
Co-authored-by: terryc33x <64039851+terryc33x@users.noreply.github.com>
Co-authored-by: Terry Chen <terry.chen@33across.com>

* Prebid 4.15.0 Release

* Increment pre version

* Improve Digital adapter: eids support (#5935)

* Improve Digital adapter: eids support

* Fix quotes

* Adkernel: andbeyond alias (#5922)

* LunamediaHB bid adapter (#5906)

* Add User ID Targeting to googletag.cmd as a fallback when GPT API is not ready (#5925)

* Add User IDs to googletag.cmd

The purpose of this change is to allow the userIdTargeting module to function even when googletag has not been defined yet.

* Fixing indentation errors

Fixing indentation errors thrown by

* Fix 'googletag' is not defined errors

* Added unit test for userIdTargeting fallback

* No bid version 1.2.9 (#5794)

* Enable supplyChain support

* Added support for COPPA

* rebuilt

* Added support for Extended User IDs.

Co-authored-by: Reda Guermas <reda.guermas@nobid.io>

* EMX Adding Schain forwarding (#5946)

* adding ccpa support for emx_digital adapter

* emx_digital ccpa compliance: lint fix

* emx 3.0 compliance update

* fix outstream renderer issue, update test spec

* refactor formatVideoResponse function to use core-js/find

* Add support for schain forwarding

Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com>
Co-authored-by: Nick Colletti <gnomish@gmail.com>
Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com>
Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com>
Co-authored-by: EMXDigital <emxdigital@emxdigital.com>

* pubGENIUS bid adapter: fix bug that requestBids timeout is not respected (#5940)

* fix requestBids timeout

* fix pubgenius bid adapter test

* Updated the text in line 292 (#5937)

Updated the text in line 292

* Update for Qwarry bid adapter (#5936)

* qwarry bid adapter

* formatting fixes

* fix tests for qwarry

* qwarry bid adapter

* add header for qwarry bid adapter

* bid requests fix

* fix tests

* response fix

* fix tests for Qwarry bid adapter

* add pos parameter to qwarry bid adapter

Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>

* Adagio Bid Adapter: support UserId's (#5938)

* userId module: fix auctionDelay submodules with callbacks (#5891)

* clearTimeout only after all submodules are done

* check that setTimeout function was not cleared

* fix circle ci failing lint error (#5952)

* PR-Review process: fleshing out RTD review (#5948)

* PR-Review process: fleshing out RTD review

* align bidrequest attribute

* delete pubcommon test cookie for domainOverride after writing it in all cases (#5943)

* delete pubcommon test cookie after writing it in all cases, not just when it is found again

* fix lunamediahbBidAdapter lint issue

* call domainOverride only when needed in the module, not ahead of time when the module is registered.

* Gamoshi - Add new alias (#5895)

* add logic to prefer prebid modules over external modules in build process (#4124)

* add check in getModules helper function

* update logic based on feedback

* update node version of project

* Improve Digital adapter: adding bid floor, referrer, more native fields (#4103)

* Bid floor, https, native ad update

* Update the ad server protocol module

* Adding referrer

* YIELDONE adapter - change urls to adapt https (#4139)

* update: change urls to adapt https

* fix test code

* Added SupplyChain Object support and an onTimeout Callback (#4137)

* - Implemented the 'onTimeout' callback to fire a pixel when there's a timeout.
- Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md

* some mods to the schain tag generation

* - added tests for schain param checking.

* - fixed a malformed url for timeouts

* - Removed a trailing ',' while generating a schain param.

* Revert "Added SupplyChain Object support and an onTimeout Callback (#4137)"

This reverts commit e61b246b45bd2c2390350eaeca693f208b1a3a24.

This commit doesn't use the schain module added in #4084

* Nobid Prebid Adapter commit (#4050)

* Nobid Prebid Adapter commit

* Fixed global replace and unit tests

* Fixed find function

* Added nobidBidAdapter.md

* Removed description and added "Bid Params" section.

* Added test siteId 2 for testing.

* Refactored the Adapter to remove most references to the nobid object. We still need the nobid object because we have a passback tag in DFP that makes reference to it.

* Fix concurrent responses on the page

* Cosmetic change to log an error in case of missing ad markup

* Keep nobid.bidResponses cross adapters.

* Added GDPR support in user sync and added test coverage.
gulp test-coverage
gulp view-coverage

* Padding issues

* Fix padding issues

* Fix padding

* update outstream prod url (#4104)

* support pubcid and uids (#4143)

* Fix misspelling and minor cleanup of schain docs (#4150)

* Prebid 2.31.0 Release

* Increment pre version

* Rubicon: tuning logged messages (#4157)

* Rubicon: tuning logged messages

* Update rubiconBidAdapter.js

* fixed indentation

* Rubicon Video COPPA fix (#4155)

* Rubicon Video COPPA fix

* Unit test for Rubicon Video COPPA fix

* Playground XYZ adapter - iframe usersync bug fix (#4141)

* corrected user sync type

* removed support for iframe usersync

* added unit tests for getUserSyncs

* update nvmrc file (#4162)

* update gulp-footer package (#4160)

* Datablocks bid/analytics adapter (#4128)

* add datablocks Analytics and Bidder Adapters

* remove preload param

* remove preloadid

* better coverage of tests

* better coverage

* IE doesn't support array.find

* lint test

* update example host

* native asset id should be integer

* update logic of ad_types field in appnexusBidAdapter (#4065)

* Shorten SomoAudience to just Somo (#4163)

* Shorten SomoAudience to just Somo

* Make package-lock return

* Quantcast: Fix for empty video parameters (#4145)

* Copy params from bid.params.video.

* Added test for missing video parameters.

* Include mimes from adunit.

* One Video adding Rewarded Video Feature (#4142)

* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Module to pass User Ids to DFP (#4140)

* first commit

* renamed

* minor doc change

* documentation

* small change

* EB

* removed unused imports

* minor changes

* reanmaed a const

* adding more methods to test shareUserIds module

* unit tets cases for shareUserIds

* indentation

* renamed DFP to GAM

* renamed shareUserIds to userIdTargeting

* Update userIdTargeting.md

* trying to restart CI

* digitrust userId case handled

* minor comment change

* using auctionEnd event instead of requestBids.before

* using events.on

* Buzzoola bid adapter (#4127)

* initial commit for buzzoola adapter

* leave only banners for now

* fix bid validation

* change endpoint url

* add video type

* restore renderer

* fix renderer

* add fixed player sizes

* switch bids

* convert dimentions to strings

* write tests

* 100% tests

* remove new DOM element creation in tests

* handle empty response from server

* change description

* E2e tests for Native and Outstream video Ad formats. (#4116)

* reorganize e2e/ tests into separate directories

* new test page for e2e-banner testing

* add test to check if Banner Ad is getting loaded

* change location of the spec files to reflect change in test/e2e directory structure

* add test case to check for generation of valid targeting keys

* create Native Ad test page

* add test case to check validity of the targeting keys and correct rendering of the Ad

* update old browser versions to new

* update browser version

* update title

* remove console.log statements

* add basic functional test for e2e outstream video ad format

* Update LockerDome adUnitId bid param (#4176)

This is not a breaking change

* fix several issues in appnexus video bids (#4154)

* S2s testing disable client side (#4123)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* New testServerOnly flag

* Tests and a bug fix

* Removed dead code

* Fixes requested in review

* Check each adUnit

* isTestingServerOnly changes per Eric

* Fixed IE 11 bug

* More tests

* improved test case names

* New option to Include deal KVPs when enableSendAllBids === false (#4136)

* new option to include KVPs which have deals when
enableSendAllBids === false

* updating tests to be more realistic

* Prebid 2.32.0 Release

* increment pre version

* Rubicon doc: changing video test zone (#4187)

* added schain support to sonobi adapter (#4173)

* if schain config is not defined then error should not be thrown (#4165)

* if schain config is not defiend then error should not be thrown

* relaxed mode nodes param not defined error handled

* added test cases for config validation

* a curly bracket was missing in the example

* Rubicon: updating test params (#4190)

* myTargetBidAdapter: support currency config (#4188)

* Update README.md (#4193)

* Update README.md

* Update README.md

* cedato bid adapter instream video support (#4153)

* Added adxpremium prebid analytics adapter (#4181)

* feat(OAFLO-186): added support for schain (#4194)

* Sonobi - send entire userid payload (#4196)

* added userid param to pass the entire userId payload to sonobis bid request endpoint

* removed console log
git p

* fixed lint

* OpenX Adapter fix: updating outdated video examples (#4198)

* userId - Add support for refreshing the cached user id (#4082)

* [userId] Added support for refreshing the cached user id: refreshInSeconds storage parameter, related tests and implementation in id5 module

* [userId] Added support for refreshing the cached user id: refreshInSeconds storage parameter, related tests and implementation in id5 module

* UserId - ID5 - Updated doc with new contact point for partners

* UserId - Merged getStoredValue and getStoredDate

* [UserId] - ID5 - Moved back ID5 in ./modules

* UserId - ID5 - Fixed incorrect GDPR condition

* [UserId] - Doc update and test cleanup

* Prebid 2.33.0 Release

* Increment pre version

* SupplyChainObject support and fires a pixel onTimeout (#4152)

* - Implemented the 'onTimeout' callback to fire a pixel when there's a timeout.
- Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md

* some mods to the schain tag generation

* - added tests for schain param checking.

* - fixed a malformed url for timeouts

* - Removed a trailing ',' while generating a schain param.

* - Using the schain object from validBidRequest if present. Reverting to checking if params has it if not.

* - reverting changes to merge with master

* - Resolving merge issues

* Feature/add profile parameter (#4185)

* Add optional profile parameter

* EMXDigital Bid Adapter: Add video dimensions in request (#4174)

* addressed feedback from #3731 ticket

* removed commented code from emx test spec

* logging removed from spec

* flip h & w values from playerSize for video requests

* adding Outstream mediaType to EMX Digital

* adding device info. update to grab video param. styling changes.

* add video dimensions from playerSize

* fix test for video dimensions

* Added keywords parameter support in TrustX Bid Adapter (#4183)

* Add trustx adapter and tests for it

* update integration example

* Update trustx adapter

* Post-review fixes of Trustx adapter

* Code improvement for trustx adapter: changed default price type from gross to net

* Update TrustX adapter to support the 1.0 version

* Make requested changes for TrustX adapter

* Updated markdown file for TrustX adapter

* Fix TrustX adapter and spec file

* Update TrustX adapter: r parameter was added to ad request as cache buster

* Add support of gdpr to Trustx Bid Adapter

* Add wtimeout to ad request params for TrustX Bid Adapter

* TrustX Bid Adapter: remove last ampersand in the ad request

* Update TrustX Bid Adapter to support identical uids in parameters

* Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request

* Update TrustX Bid Adapter to support instream and outstream video

* Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter

* Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl

* HOTFIX for referrer encodind in TrustX Bid Adapter

* Fix test for TrustX Bid Adapter

* TrustX Bid Adapter: added keywords passing support

* rubicon: avoid passing unknown position (#4207)

* rubicon: not passing pos if not specified

* added comment

* not sending pos for video when undefined

* cleaning up test

* fixed unit test

* correctly reference bidrequest and determine mediatype of bidresponse (#4204)

* GumGum: only send gdprConsent when found (#4205)

* adds digitrust module, mods gdpr from bool to int

* update unit test

* only send gdprconsent if present

* LKQD: Use refererInfo.referer as fallback pageurl (#4210)

* Refactored URL query parameter passthrough for additional values, changed SSP endpoint to v.lkqd.net, and updated associated unit tests

* Use refererInfo.referer as fallback pageurl

* Removed logs and testing values

* [UserId] - ID5 - Fixed case when consentData is undefined (No CMP) (#4215)

* create stubs for localStorage in widespaceBidAdapter test file (#4208)

* added adId property to adRenderFailed event (#4097)

When no bid (therefore no adUnitCode) is available in the adRenderFailed event it can be difficult to identify the erroring slot.But in almost all cases the given slot still has the adId targeting.

* OpenX Adapter: Forcing https requests and adding UserID module support for LiveRamp and TTD (#4182)

* OpenX Adapter: Updated requests to force https

* OpenX Adapter: Added support for TTD's UnifiedID and LiveRamp's IDL

* PubMatic to support userId sub-modules (#4191)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* TripleLift support for UnifiedId and IdentityLink (#4197)

* Add IdentityLink support and fix UnifiedId.

It appears we've been looking for UnifiedId userIds
on the bidderRequest object, when they are found on bidRequests.
This commit fixes that error, and adds support for IdentityLink.

* change maintainer email to group

* Added lemma adapter (#4126)

* lemmaBidAdapter.js

Added lemma bid adapter file

* lemmaBidAdapter.md

Added lemma bid adapter md file

* lemmaBidAdapter_spec.js

Added lemma bid adapter test spec file

* Update lemmaBidAdapter.js

Fixed automated code review alert comparison between inconvertible types

* Update lemmaBidAdapter.js

Fixed review changes

* Update lemmaBidAdapter.md

Correct parameter value.

* Adkernel adapter new alias (#4221)

* Force https scheme for Criteo Bidder (#4227)

* assign adapter version number

* Ensure that Criteo's bidder is always called through https

* Add Video Support for Datablocks Bid Adapter (#4195)

* add datablocks Analytics and Bidder Adapters

* remove preload param

* remove preloadid

* better coverage of tests

* better coverage

* IE doesn't support array.find

* lint test

* update example host

* native asset id should be integer

* add datablocks Video

* remove isInteger

* skip if empty

* update adUnit, bidRequest and bidResponse object (#4180)

* update adUnit, bidRequest and bidResponse object

* add test for mediaTypes object

* 3 display banner and video vast support for rads (#4209)

* add stv adapter

* remove comments from adapter file

* start rads adapter

* fix adapter and tests

* fixes

* fix adapter and doc

* fix adapter

* fix tests

* little fix

* add ip param

* fix dev url

* #3 radsBidAdapter.md

* #3 radsBidAdapter.md: cleanup

* fix code and doc

* UserId - Add SameSite and server-side pubcid support (#3869)

* Add SameSite and server-side pubcid support

* Fix emoteevBidAdapter unit test

* added schain to appnexus bid adapter (#4229)

* added schain to appnexus bid adapter

* semicolon

* update doubleclick url (#4179)

* Prebid 2.34.0 release

* increment pre version

* Rubi Analytics handles > 1 bidResponse per bidRequest (#4224)

* videoNow bid adapter (#4088)

* -- first commit

* -- cors and bidder's name fixed

* -- almost ready

* -- added docs

* -- added nurl tracking

* -- bid params

* -- tests added

* -- test fixed

* -- replace placeholder in the onBidWon pixel's url

* -- commit for restart tests

* -- change response data format for display ad

* -- tests updated

* -- 100% tests coverage

* -- a few clean the test's code

* -- custom urls from localStorage

* -- tests updated

* -- a few clean the test's code

* -- new init model

* -- spec for new init model

* -- fix for new init model

* -- code cleaned

* -- 100% tests coverage

* -- 100% tests coverage

* -- fixed test

* -- commit for restart tests

* djax new bidder adapter  (#4192)

* djax bidder adapter

* djax bidder adapter

* Update hello_world.html

* Added Turk Telekom Bid Adapter (#4203)

* Added Turk Telekom Bid Adapter

* Fix md file for Turk Telekom Bid Adapter

* MicroAd: Use HTTPS in all requests (#4220)

* Always use HTTPS endpoint in MicroAd

* Update code

* Fixed a broken test in MicroAd

* Schain: avoiding Object.values as it is breaking on IE11 (#4238)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* avoiding use of Object.values

* 3952 delay auction for ids (#4115)

* 3952 delay auction for user ids

* 3952 add integration example

* 3952 add tests

* 3952 fix html example

* add todos

* 3952 continue auction if ids received

* 3952 add tests for auction delay

* increase test coverage

* set config for test

* remove todo

* add a few more checks to tests

* add comment, force tests to rerun

* Feature: adUnitBidLimit  (#3906)

* added new feature to config to limit bids when sendallbids is enabled

* cleaned up code. removed extra spaces etc

* removed trailing spaces in config

* remove .flat() and replaced with spread operator

* removed flat function and instead pushing using spread operator

* updated to use sendBidsControl instead

* updated targeting_spec to test bidLimit

* removed trailing spaces from targeting_spec

* Update Rubicon Adapter netRevenue default (#4242)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Removed AdastaMadia from alias (#4255)

* Update appnexusBidAdapter.js (#4251)

* IdentityLink - change expiration time to 30 days (#4239)

* Add coppa support for AppNexus adapter (#4253)

* Add coppa support for AppNexus adapter

* test name

* add new longform e2e tests (#4206)

* Konduit module (#4184)

* Adding Konduit module

* Removed superfluous arguments passed to obtainVastUrl function

* Removed superfluous arguments passed to obtainVastUrl function.

* Build trigger (empty commit)

* Module documentation updated according to the comments

* Logic in obtainVastUrl function updated according to the review comment.

* Removed hook, enabled eslint

* Circle CI runs e2e tests on every push (#4200)

* run functional tests on circle ci on push to any remote branch

* remove extraneous key from config file

* add test.localhost as alias to 127.0.0.1

* check 0: execute circle-ci

* move /etc/config to a separate command

* change bid partner to rubicon

* test appnexus bid adapter in ci

* comment browserstack command

* remove console.log statement

* test1: circle-ci

* change reference dev -> prod while loading prebid

* add console.log statement

* check-2: circle-ci

* comment browserstack testing

* change bid adapter

* change bid adapter

* remove test case for checking targeting keys

* remove the ci flag

* uncomment test for checking correct generation of targeting keys

* swap AN -> Rubicon for testing targeting keys

* Outcon bid adapter. (#4161)

* Outcon bid adapter.

* Fix identation

* Fixes

* Fixes

* Fixes

* Spec fixes

* Fixes

* Fix urls

* Fix

* Fix parameters

* Fix space operators

* Fix bidder timeout

* Update

* Fix whitespace

* no message

* Outcon unit test

* no message

* no message

* no message

* no message

* Fixes

* Fixes

* Change url

* no message

* no message

* no message

* Added bidId

* no message

* no message

* no message

* no message

* Wrapping url with html

* no message

* no message

* no message

* Adding workflow to run end to end tests (#4230)

* Adding workflow to run end to end tests

* trying self branch

* Update to run at 12 every day

* cleanup config using aliases

* update branch and cron time

* add command

* update prebid path for e2e test pages (#4274)

* Prebid 2.35.0 release

* Increment pre version

* Add usersync to adpone adapter (#4245)

* add user sync to adpone adapter

* move adpone usersync to global variable

* added withcredentials to http request

* fix http request options

* fix http request options

* add withCredentials: true

* add withCredentials: true

* added test coverage to usersync

* update sync function

* add test coverage

* adpone adapter

* package lock

* add more testing

* add more testing

* testing for onBidWon fucntion

* test onbidwon function

* trigger build

* Revert GumGum Adapter 2.28 resizing changes (#4277)

* changed resizing unit tests to return the first size dimensions in the sizes array

* added some changes

* reverted adapter changes

* SpotX Bid Adapter: Support schain, ID5 object, Google consent object, and hide_skin (#4281)

* Add SpotXBidAdapter

* Minor updates

* Undo testing changes to shared files

* Fix relative imports

* Remove superfluous imports and write a few more tests

* Formatting, ID5 object, Google consent objects

  - Added ID5 object support
  - Added Google Consent object
  - Reformatted indentaiton on spec file

* Revert content_width and content_height changes in docs

  - not sure how these got moved, lets put them back

* Remove click_to_replay flag in example

  - no reason to use this one in the example

* Spotx adapter - Add schain support and update unit tests

* Update schain path in ORTB 2.3 request body

	- schain object is now added to ortb request body
	  at request.ext.source.ext.schain

* Add hide_skin to documentation

  - whoops, this got removed, let's add it back

* Update Rubicon Analytics Adapter `bidId` to match PBS (#4156)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update for rubicon analytics to send seat[].bid.id for PBS video and banner

* fixed conditional for server and video or banner

* updated with optimized value test for bidid

* update changed default value of netRevenue to true

* remove var declaration for rightSlot to correct lgtm error for unused variable

* update defineSlot div id to match div id defined in html body

* update test ad unit test props

* revert lock to match remote master

* add seatBidId to bidObj in rpBidAdapter interpretResponse

* update setTargeting to execute in the bids back handler

* remove dev integration test page

* meaningless commit to get lgtm to re-run

* SmartRTB adapter update (#4246)

* modules: Implement SmartRTB adapter and spec.

* Fix for-loop syntax to support IE; refactor getDomain out of exported set.

* Remove debugs, update doc

* Update test for video support

* Handle missing syncs. Add video to media types in sample ad unit

* Add null response check, update primary endpoint

* Note smrtb video requires renderer

* Support Vast Track (#4276)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Add parameters if config.cache.vasttrack is true

* Use requestId instead of adId

* Test new vasttrack payload params

* Removed commented out code

* Relaxed conditional check per review

* Removed commented out line

* Added 1000x250 size (#4295)

* prepare vidazoo adapter for v3.0 (#4291)

* Improve Digital adapter: support schain (#4286)

* LiveIntent Identity Module. (#4178)

* LiveIntentIdSystem. Initial implementation.

* LiveIntentIdSystem. Removed whitespace.

* Fixed typo

* Renamed variables, cookiesm added md.

* Changed the default identity url.

* Composite id, with having more than just the lipbid passed around.

* Composite id.

* Merge conflict resolution.

* Changed docs and param description.

* Added typedoc & mentioned liveIntentIdSystem in submodule.json.

* Extracted the LiveIntentIdSystem under modules, removed it from default userId modules.

* Fixing the 204 + no body scenario.

* Added liveIntent to submodule.json

* Fixing docs indentation.

* Updated prebidServer & specs.

* Minor specs update.

* updating liveintent eids source (#4300)

* updating liveintent eids source

these are supposed to be domains

* updating unit test

* fix appnexusBidAdapter view-script regex (#4289)

* fix an view script regex

* minor syntax update

* 33Across adding bidder specific extension field (#4298)

* - add 33across specific ext field for statedAt

* - fix unit test for 33Across adapter

* PubMatic to support LiveIntent User Id sub-module (#4306)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* supporting LiveIntent Id in PubMatic adapter

* updated source for liveintent

* Finteza Analytics Adapter: fix cookies (#4292)

* fix reading and sending cookies

* fix lint errors

* clear comments

* add unit tests

* fix calling of setCookies for IE

* clear cookies after test

* use own setCookie method inside tests

* Update LockerDome adapter to support Prebid 3.0 (#4301)

* Returning the `IdResponse` type with an obj + callback. Fix for 4304 (#4305)

*  Returning the `IdResponse` type with an obj + callback.

* Renamed resp -> result.

* Removed whitespace.

* ShowHeroes adapter - expanded outstream support (#4222)

* add ShowHeroes Adapter

* ShowHeroes adapter - expanded outstream support

* Revert "ShowHeroes adapter - expanded outstream support"

This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51.

* ShowHeroes adapter - expanded outstream support

* ShowHeroes adapter - fixes (#4222)

* ShowHeroes adapter - banner and outstream fixes (#4222)

* ShowHeroes adapter - description and outstream changes (#4222)

* ShowHeroes adapter - increase test coverage and small fix

* [Orbidder-Adapter] Add bidRequestCount and remove bid.params.keyValues (#4264)

* initial orbidder version in personal github repo

* use adUnits from orbidder_example.html

* replace obsolete functions

* forgot to commit the test

* check if bidderRequest object is available

* try to fix weird safari/ie issue

* ebayK: add more params

* update orbidderBidAdapter.md

* use spec.<function> instead of this.<function> for consistency reasons

* add bidfloor parameter to params object

* fix gdpr object handling

* default to consentRequired: false when not explicitly given

* wip - use onSetTargeting callback

* add tests for onSetTargeting callback

* fix params and respective tests

* remove not used bid.params.keyValues

* add bidRequestCount to orbidder.otto.de/bid Post request

* add bidRequestCount to test object defaultBidRequest

* PulsePoint: remove usage of deprecated utils method / prep for 3.0 (#4257)

* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per https://github.com/prebid/Prebid.js/issues/509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866

* Minor fix

* Adding mandatory parameters to Bid

* Removing usage of deprecated utils method

* minor refactor

* Use isArray method (#4288)

* Add Parrable ID submodule (#4266)

* add parrable id submodule

* fix integration test config

* fix var name

* always refresh sotredId for parrable

* add submodulesThatAlwaysRefresh concept

* remove comment

* add parrable url as one string

* add parrable prod endpoint

* use .indexOf instead of .includes

* add params to test config

* comment failing test

* uncomment failing assertion

* add parrable ID to prebid server adapter

* add parrableIdSystem to .submodules.json

* extract parrableId unit tests from userId spec

* remove breakline between imports

* remove unused param

* remove userId generic feature from parrableId module

* remove trailing space

* fix failing test due to none merged conflict

* Prebid 2.36.0 Release

* Increment pre version

* Support schain module and send bidfloor param in Sharethrough adapter (#4271)

* Add support for supply chain object module

Story: [#168742394](https://www.pivotaltracker.com/story/show/168742394)

Co-authored-by: Josh Becker <jbecker@sharethrough.com>

* Add bidfloor parameter to bid request sent to STX

Story: [#168742573](https://www.pivotaltracker.com/story/show/168742573)

* Platform One Analytics Adapter (#4233)

* Added Y1 Analytics Adapter

* rename y1AnalyticsAdapter in yieldoneAnalyticsAdapter

* Yieldone Bid Adapter: fixes from lint check

* Yieldone Analytics Adapter: fix endpoint protocol

* Added spec file for yieldone Analytics Adapter

* Fix parrable id integration example (#4317)

* fix parrableId integration example

* add parentheses

* Improve Digital adapter: support for video (#4318)

* Bid floor, https, native ad update

* Update the ad server protocol module

* Adding referrer

* Improve Digital support for video

* Improve Digital adapter: video

* adapter version -> 6.0.0

* Gamoshi: Update aliases list. Add support for userSync. (#4319)

* Add support for multi-format ad units. Add favoredMediaType property to params.

* Add tests for gdpr consent.

* Add adId to outbids

* Modify media type resolving

* Refactor multi-format ad units handler.

* Modify the way of sending GDPR data.
Update aliases.

* Add new consent fields. Add unit test.

* Add new consent fields. Add unit test.

* Add support for id5 and unified id cookie sync.

* Add support for id5 and unified id cookie sync.

* Add restricted check for gdpr consent.

* fix for userSync endpoint getting called with bidder alias names, instead of actual bidder names (#4265)

* modify ixBidAdapater to always use the secure endpoint (#4323)

* PubMatic to support Parrable User Id sub-module (#4324)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* PubMatic to support parrable id

* VISX: currency validation & fix double escape of referer (#4299)

* PubMatic to support coppa (#4336)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* added coppa compliance

* vuble: outstream has fullscreen option (#4320)

* Mod: vuble oustream has fullscreen option

* Add: vuble test for outstream scenario

* EMXDigital: hotfix to resolve URIError from decodeURIComponent (#4333)

* hotfix to resolve URIError from decodeURIComponent

* added unit for decoding adm

* Specify second parameter for parseInt for pubmaticBidAdapter (#4347)

* Remove usage of getTopWindowUrl in Prebid Adapter (#4341)

* Conversant Bid Adapter update for 3.0 (#4284)

* Add cpmDistribution function for Google Analytics adapter (#4240)

* Add cpmDistribution function for Google Analytics adapter

* Add test for the cpmDistribution function

* Remove half written comment

* fixing SRA p_pos (#4337)

* In Sonobi Adapter, only read sizes from bid.mediaTypes (#4311)

* Fix mediaTypes (#4332)

* Outcon bid adapter.

* Fix identation

* Fixes

* Fixes

* Fixes

* Spec fixes

* Fixes

* Fix urls

* Fix

* Fix parameters

* Fix space operators

* Fix bidder timeout

* Update

* Fix whitespace

* no message

* Outcon unit test

* no message

* no message

* no message

* no message

* Fixes

* Fixes

* Change url

* no message

* no message

* no message

* Added bidId

* no message

* no message

* no message

* no message

* Wrapping url with html

* no message

* no message

* no message

* Fix mediaTypes

* no message

* Update outconBidAdapter_spec.js

* Adding VAS response

* no message

* no message

* no message

* Fix

* Changed ttl

* no message

* supportedMediaTypes

* no message

* no message

* Prebid 2.37.0 release

* increment pre version

* Add vast xml support and other minor changes to Beachfront adapter (#4350)

* Add support for vast xml in the bid response

* add secure protocol to outstream player url

* add device connection type

* add player setting for poster color

* add new value for creative Id

* Update smartrtbBidAdapter (#4362)

* modules: Implement SmartRTB adapter and spec.

* Fix for-loop syntax to support IE; refactor getDomain out of exported set.

* Remove debugs, update doc

* Update test for video support

* Handle missing syncs. Add video to media types in sample ad unit

* Add null response check, update primary endpoint

* Note smrtb video requires renderer

* Remove old params checks, fix documentation playerSize field name

* Revert "Update smartrtbBidAdapter (#4362)" (#4368)

This reverts commit be6704bcec65a28d80b6d09a8d1c51ef9a8ba824.

* Add userSync in onetagBidAdapter (#4358)

* Minor bug fixing in onetagBidAdapter.js

Fixed a minor bug. Updated TTL in response to align the correct specifications.

* Update onetagBidAdapter

Added additional page info and user sync function.

* Update onetagBidAdapter_spec.js

Added the test for getUserSyncs function.

* Fix about userSync

* getUserSyncs: test update with gdpr params

* Sovrn adapter updates: schain, digitrust, pixel syncing, and 3.0 upgrades (#4335)

* schain and digitrust

* pixel beacons

* unit tests and fixes from testing

* Prebid 3.0 updates

* review fix

* Add bid adapter for ablida (#4256)

* Add ablida adapter

* rename category parameter, add documentation

* AdKernel: added waardex_ak alias (#4290)

* added alias

Added a new alias

* fixing unit test

* Revert "Sovrn adapter updates: schain, digitrust, pixel syncing, and 3.0 upgrades (#4335)" (#4376)

This reverts commit 6114a3dba93815dcfb535707d7b4d84f1adb2bc7.

* Vrtcal Markets Inc. Bid Adapter Addition (#4259)

* Added 3 key Vrtcal Adapter files: adapter,markdown,unit tests

* Removed unused getUserSyncs;Added mediaTypes.banner.sizes support;Raised test coverage to 85%

* lint formatting errors corrected

* Update schain path in ORTB path for spotxBidAdapter (#4377)

- Move schain object from request.ext.source.ext.schain to
	  request.source.ext.schain

* Update Grid Bid Adapter (#4379)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Add video support in Grid Bid Adapter

* Added test parameter for video slot

* update Grid Bid Adapter to set size in response bid

* Update Grid Bid Adapter to support identical uids in parameters

* Fix typo in test file for Grid Bid Adapter

* Update The Grid Media Bidder Adapter to send refererInfo.referer as 'u' parameter in ad request

* Hotfix for referrer in Grid Bid Adapter

* Grid Bid Adapter: added wrapperType and wrappweVersion to the ad request

* TripleLift: Sending schain (#4375)

* Add IdentityLink support and fix UnifiedId.

It appears we've been looking for UnifiedId userIds
on the bidderRequest object, when they are found on bidRequests.
This commit fixes that error, and adds support for IdentityLink.

* change maintainer email to group

* TripleLift: Sending schain (#1)

* Sending schain

* null -> undefined

* DistrictmDMX: adding support for schain and remove content type to default to prebid selection (#4366)

* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location

* current machine state

* lint correction

* remove variable assigment duplicate

* Support for ID5 + receive meta data (#4352)

* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed

* Added support for Publisher Common ID Module

* Corrections for ttr in analytics

* ANalytics updates

* Auction start time stamp changed

* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter

* Collect info on ad units receiving any valid bid

* Support for ID5
Pass metadata from adapter

* Typo in test + eids on wrong level

* Rubicon Adapter: Always make requests using HTTPS (#4380)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Always make bids requests using https

* rp_secure and imp.secure should always be 1

* 7xbid adapter (#4328)

* 7xbid adapter

* fix error when cli build

* - update 33across adapter cookie sync end point (#4345)

- update unit test for 33across adapter

* Adform adapter: add renderer for outstream bids (#4363)

* Prebid 2.38.0 Release

* Increment pre version

* Adagio: update with external js (#4217)

* Add external loader in AdagioBidAdapter

* Change adagioAnalyticsAdapter to "endpoint" type

* Change _setPredictions for a generic method

* Improve AdagioBidAdapter test coverage

* Add features detection in Adagio adapter

* Fix adagioBidAdapter tests

* Add featuresVersion field to bidRequest

* Refacto adagio.queue

* Expose versions in ADAGIO namespace

* Generate a ADAGIO.pageviewId if missing

* Move ad-server events tracking to adagioBidAdapter

* Store adUnitCodes in ADAGIO namespace

* Update documentation

Better description of test parameters.

* Add internal array to prevent empty pbjs.adUnits

* Be sure to access to window.top - does not work in safe-frame env

* Add PrintNumber feature

* Be sure to compute features on window.top

* Bump versions

* Add Post-Bid support

- ad-server events are listen in current window (instead of window.top)
- a new "outerAdUnitElementId" property is set to ADAGIO.pbjsAdUnits array in case of Post-Bid scenario. This property is the 1st parent element id attribute of the iframe in window.top.

* Set pagetype param as optional

* Add AdThink ad-server support

* Improve internal `pbjsAdUnits.sizes` detection

Use the adUnit `mediaTypes.banner.sizes` property if exists to build the `ADAGIO.pbjsAdUnits.sizes`.
The use of the `sizes` root property is deprecated.

* adagioAnalyticsAdapter: add and improve tests

* adagioBidAdapter: add and improve tests

# Conflicts:
#	modules/adagioBidAdapter.js
#	test/spec/modules/adagioBidAdapter_spec.js

* adagioBidAdapter: Bump version 1.5

* Adagio: fix import path

* PostBid: insure window.top is accessible for specifics functions

* Consistency: use Prebid.js utils and fix deprecated

* PostBid: do not build a request if in safeframe

* Bump version 2.0.0

* Try to fix tests without UA stubing

* Try to fix adagioAnalytics failling tests on CI

* Consistency: use Prebid loadExternalScript()

* Add "adagio" to Prebid.js adloader vendor whitelist

* Remove proprietary ad-server listeners

* Add RSA validation to adagio external script

* add viewdeosDX whitelabel (#4231)

* add viewdeosDX hitelabel

* Fixed tests and support for sizes

* Fix strings

* Fix strings

* remove only

* Fix tests

* fix codereview

* Fix test + Code review

* code review + tests

* One video display ad (#4344)

* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* testing display ad

* adding banner

* validating banner object

* display=1 changes

* checking whether diplsy == 1

* html page change

* reverting video.html

* adding more test cases

* spaces

* md file change

* updated working oneVideoBidAdapter.md file

* Update oneVideoBidAdapter.md

* Update oneVideoBidAdapter.md

* updated the file with both video params and banner

* Update video.html

* fix double-urlecoded referrer (#4386)

* fix double-urlecoded referer (#4388)

* PulsePoint Adapter - update for ttl logic (#4400)

* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per https://github.com/prebid/Prebid.js/issues/509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866

* Minor fix

* Adding mandatory parameters to Bid

* Using the TTL from the bid.ext

* Minor refactor

* IdentityLink - add logic for sending consent string (#4346)

* Fix adagio analytics adapter circleci (#4409)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* update to skip broken circleci tests

* skip all

* Feature/7xbid remove unneeded params (#4402)

* 7xbid adapter

* fix error when cli build

* remove unneeded params

* Empty commit

* Empty commit

* Remove none ssl (#4406)

* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location

* current machine state

* lint correction

* remove variable assigment duplicate

* remove none ssl element from all request]

* fixed reference to global object (#4412)

* ucfunnel adapter support supply chain (#4383)

* Add a new ucfunnel Adapter and test page

* Add a new ucfunnel Adapter and test page

* 1. Use prebid lib in the repo to keep updated
2. Replace var with let
3. Put JSON.parse(JSON.stringify()) into try catch block

* utils.getTopWindowLocation is a function

* Change to modules from adapters

* Migrate to module design

* [Dev Fix] Remove width and height which can be got from ad unit id

* Update ucfunnelBidAdapter to fit into new spec

* Correct the endpoint. Fix the error of query string

* Add test case for ucfunnelBidAdapter

* Fix lint error

* Update version number

* Combine all checks on bid request

* Add GDPR support for ucfunnel adapter

* Add in-stream video and native support for ucfunnel adapter

* Remove demo page. Add more test cases.

* Change request method from POST to GET

* Remove unnecessary comment

* Support vastXml and vastUrl for video request

* update TTL to 30 mins

* Avoid using arrow function which is not discuraged in mocha

* ucfunnel tdid support

* ucfunnel adapter support supply chain

* LiveIntent support in RP Adapter and PBS Adapter update to pass segments (#4303)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* added semi-colon

* update eid source to use domain

* update video oRTB with liveintent segments

* update pbs adapter with liveintent segments support

* update rp adapter liveintent support for fastlane

* reverted package lock, fix for unintentional update

* added unit tests for fastlane.json and ortb, fix to join segments with commas

* fix obj property path data.tpid

* update remove unnecessary function call

* re-ordering query string params

* Rubicon Adapter: Add multiple sizes to sizeMap (#4407)

* Add Utils to remove item in LocalStorage (#4355)

* Making originalCpm and originalCurrency fields in bid object always available (#4396)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* moving originalCurrency declaration from currency to bidderFactory

* added a comment

* trying to re-run the CI job

* added unit test case

* trying to re-run the CI job

* Placement and inventory (#4353)

* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* inventory_id and placement

* removed unnecessary file

* lint error

* Update oneVideoBidAdapter.js

* lint error fix

* Fixes for Platform One Analytics Adapter (#4359)

* Added Y1 Analytics Adapter

* rename y1AnalyticsAdapter in yieldoneAnalyticsAdapter

* Yieldone Bid Adapter: fixes from lint check

* Yieldone Analytics Adapter: fix endpoint protocol

* Added spec file for yieldone Analytics Adapter

* Add adUnitName to analytics data for Yieldone Analytics Adapter

* Fix yieldone Analytics Adapter to log only id from adUnitPath

* Fix bug with timeout event in Yieldone Analytics Adapter

* Added protocol to url (#4395)

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

* modified api url

* fix

* fixed the secure api call

* rolled back video event callback till we support it

* updated doc with video details

* added bid won and timeout pixel

* added testcase for bid events

* modified testcase

* fixed the url logged

* tag param values passed ot renderer

* added a conditioal check

* changes to support new param to adserver for purpose of tracking

* passed param to renderer

* missing variable defined

* added protocol to url

* fixed test for protocol

* changed urls to secure only

* Update emoteev endpoints (#4329)

* JustPremium: Update to Prebid 3.0 (#4410)

* Update underdogmedia adapter for pbjs 3.0 (#4390)

* Update underdogmedia adapter for pbjs 3.0

* Ensure request to endpoint is secure

* Update prebid version

* Lint fix

* Update Consumable adapter for Prebid.js 3.0 (#4401)

* Consumable: Clean up tests.

* Consumable: Update use of deprecated function.

* Consumable: Read sizes from mediaTypes.banner.sizes.

* Consumable: Fix lint violation.

* CriteoId User Module (#4287)

* Add CriteoId module

* Update the return type of getId in Criteo Id module

Changes:
- Use of url parsing function from url lib
- Update the return type of getId()
- Update the jsdoc to reflect the real return types

* Fix failing tests for Criteo user module

* Add CriteoIdSystem submodule to .submodule.json.

* 2019/10/18 Create Mobsmart bidder adapter (#4339)

* Adpod deal support (#4389)

* Adpod deal support

* Replacing filterBids with minTier

* fix potential issue

* remove querystringify package (#4422)

* Browsi real time data module (#4114)

* real time data module,
browsi sub module for real time data,
new hook bidsBackCallback,
fix for config unsubscribe

* change timeout&primary ad server only to auctionDelay
update docs

* support multiple providers

* change promise to callbacks
configure submodule on submodules.json

* bug fixes

* use Prebid ajax

* tests fix

* Prebid 2.39.0 Release

* increment pre version

* OpenX Adapter: Prebid 3.0 Compatibility Update (#4413)

* Removed usage of deprecated functions
* Removed beacons
* Banner sizes now reads from bidRequest.mediaTypes.banner.sizes instead of bidRequest.sizes
* Updated tests to reflect changes.

* GumGum: use mediaTypes.banner.sizes (#4416)

* adds digitrust module, mods gdpr from bool to int

* update unit test

* only send gdprconsent if present

* uses mediaTypes before trying bidRequest sizes

* removes use of deprecated method

* RTBhouse Bid Adapter update for 3.0 (#4428)

* add viewable rendering format (#4201)

* Feature/adapter (#4219)

* feat(bidrequest): code for making bidrequest

* feat(bidresponse): format and return the response

* feat(tests): added tests for adapter

* feat(docs): added docs for the adapter

* refactor(url): changed adserver url

* test(user sync): added unit tests for the user syncs

* refactor(endpoint): changed endpoint for prebid

* refactor(endpoint): changed endpoint for prebid

* doc(tagid): mandatory param definition added

* fix(imp id): fix for correct impression id

* fix(width/height): fix for correct width and height sequence

* PulsePoint Bid Adapter: Support for schain (#4433)

* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per https://github.com/prebid/Prebid.js/issues/509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866

* Minor fix

* Adding mandatory parameters to Bid

* ET-5938 SupplyChain Object Support

* Formatting

* Code review

* Code review

* Fix to currency parsing on response

* Add supply chain support for Teads adapter (#4420)

* Rubicon: support SupplyChain (schain) (#4315)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Starting schain

* More tests for banner schain support

* Video tests

* Encoding tweaks, required fields and comments

* Removed .only() from tests

* Change requests per Bret

* Add 1ad4good bidder (#4081)

* adding bidder code and

A bidder for non-profit free ads.
more info about this bidder project can be found on project site
http://1ad4good.org

* removed unused code

test coverage is improved to >80%
tested for instream video support

* removed some legacy code, unused params

* hardcoding https to endpoint

* Improve Digital adapter fix: don't send sizes for instream video (#4427)

* Bid floor, https, native ad update

* Update the ad server protocol module

* Adding referrer

* Improve Digital support for video

* Improve Digital adapter: video

* adapter version -> 6.0.0

* Improve Digital adapter: don't send sizes for video

* Fix a typo in code comment (#4450)

* Inventory id and schain support for display (#4426)

* supporting schain

* Update coinzillaBidAdapter.js (#4438)

Update sizes const.

* Support schain in ZEDO adapter (#4441)


* changes to pass schain

* PubMatic supporting updated Criteo User Id module (#4431)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* PubMatic supporting updated Criteo User Id module

* added a comment to re-start CI

* Remove duplicate param to fix unit tests (#4459)

* Brightcom Bid Adapter update for 3.0 (#4343)

* add support for min_height field in pbs native requests (#4434)

* Supporting Alias via Video Requests (#4460)

* New adapter Proxistore (#4365)

* add test adapter and documentation

* integration test with hello_world

* reset package-lock.json

* delete useless conditionnal

* make integrate test work

* revert hello-world

* revert hello_world

* fix descriptor

* change adUnits for integration test

* remove proxistore widget

* uncomment file

* change sizes

* remove useless script tag

* Implementation of setBidderConfig and bidder-specific data (#4334)

* initial implementation of setBidderConfig

* fix ie11 test errors

* Support new setBidderConfig format. Include props from both config and bidderConfig in _getConfig

* Use core-js Set to avoid issues with IE

* Fix tests in IE

* put registerSyncs back on bidderFactory

* run bidder event methods with bidder config enabled

* Prebid 2.40.0 Release

* Increment pre version

* Conversant Bid Adapter checks pubcid directly (#4430)

* Cookie Sync functionality (#4457)

* changing PID param value for testing

* cookie sync integration

* merge from upstream

* Staq Adapter: update with meta envelope (#4372)

* initial dev

* fix staq adapter name

* fix hello world staq call

* get hello world working again

* add user agent collection

* fix some unite tests

* Add STAQ Analytics Adapter doc

* clean up hello world

* fix tests to play nice with browserstack

* fix around issues with browserstack and deep equals of objects

* dump variable env testing since we can't mod user agent stuff in browserstack

* Update STAQ adapter to stop using deprecated utils for referrer

* remove package-lock.json changes via master rebase

* improve call frequency for ref util

* change ajax content type

* adjust ajax request to not expect whitelisting

* remove superflous commented-out code

* update event package to use meta information in envelope rather than per event basis

* fix formatting

* more formatting fixes

* more formatting!

* Rhythmone Adapter - schain support (#4414)

Circle CI failing tests are not related to this PR.

* Media.net Adapter: Support Prebid 3.0 (#4378)

* Media.net Adapter: Support Prebid 3.0

* Media.net Adapter: add tests to increase code coverage

* Vi Adapter: Passes additional param in the bid request (#4134)

* Add focus check

(cherry picked from commit 9d6d6dfb83580d6a5ffed8faa5762db48f8fd44d)

* Pass focus as numeric value

(cherry picked from commit 9fae56a637f87b0d39cc1d24eeb1f9ff9df88f64)

* Add unit test

(cherry picked from commit 946710f2e9960b3839613d4bdf730e57ba38a964)

* Sovrn adapter updates: schain, digitrust, pixel syncing, and 3.0 upgrades (#4385)

* schain and digitrust

* pixel beacons

* unit tests and fixes from testing

* Prebid 3.0 updates

* review fix

* use backwards compatible flatMap impl

* update pixel tests

* unit test fix

* update one more url to ssl

* fixed test

* review updates

* TheMediaGrid Bid Adapter update (#4447)

* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Add video support in Grid Bid Adapter

* Added test parameter for video slot

* update Grid Bid Adapter to set size in response bid

* Update Grid Bid Adapter to support identical uids in parameters

* Fix typo in test file for Grid Bid Adapter

* Update The Grid Media Bidder Adapter to send refererInfo.referer as 'u' parameter in ad request

* Hotfix for referrer in Grid Bid Adapter

* Grid Bid Adapter: added wrapperType and wrappweVersion to the ad request

* TheMediaGrid Bid Adapter: added sync …
  • Loading branch information
Show file tree
Hide file tree
Showing 279 changed files with 55,443 additions and 27,906 deletions.
2 changes: 1 addition & 1 deletion .babelrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
"safari >=8",
"edge >= 14",
"ff >= 57",
"ie >= 10",
"ie >= 11",
"ios >= 8"
]
}
Expand Down
28 changes: 28 additions & 0 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@

name-template: 'Prebid $RESOLVED_VERSION Release'
tag-template: '$RESOLVED_VERSION'
categories:
- title: '🚀 New Features'
label: 'feature'
- title: '🛠 Maintenance'
label: 'maintenance'
- title: '🐛 Bug Fixes'
labels:
- 'fix'
- 'bugfix'
- 'bug'
change-template: '- $TITLE (#$NUMBER)'
version-resolver:
major:
labels:
- 'major'
minor:
labels:
- 'minor'
patch:
labels:
- 'patch'
default: patch
template: |
## In This Release
$CHANGES
18 changes: 18 additions & 0 deletions .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Release Drafter

on:
push:
# branches to consider in the event; optional, defaults to all
branches:
- master

jobs:
update_release_draft:
runs-on: ubuntu-latest
steps:
# Drafts your next Release notes as Pull Requests are merged into "master"
- uses: release-drafter/release-drafter@v5
with:
config-name: release-drafter.yml
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
16 changes: 15 additions & 1 deletion PR_REVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ If the PR is for a standard bid adapter or a standard analytics adapter, just th

For modules and core platform updates, the initial reviewer should request an additional team member to review as a sanity check. Merge should only happen when the PR has 2 `LGTM` from the core team and a documentation PR if required.

### Running Tests and Verifying Integrations

General gulp commands include separate commands for serving the codebase on a built in webserver, creating code coverage reports and allowing serving integration examples. The `review-start` gulp command combinese those into one command.

- Run `gulp review-start`, adding the host parameter `gulp review-start --host=0.0.0.0` will bind to all IPs on the machine
- A page will open which provides a hub for common reviewer tools.
- If you need to manually acceess the tools:
- Navigate to build/coverage/lcov-report/index.html to view coverage
- Navigate to integrationExamples/gpt/hellow_world.html for basic integration testing
- The hello_world.html and other exampls can be edited and used as needed to verify functionality

### General PR review Process
- All required global and bidder-adapter rules defined in the [Module Rules](https://docs.prebid.org/dev-docs/module-rules.html) must be followed. Please review these rules often - we depend on reviewers to enforce them.
- Checkout the branch (these instructions are available on the github PR page as well).
Expand All @@ -18,7 +29,10 @@ For modules and core platform updates, the initial reviewer should request an ad
- If the change results in needing updates to docs (such as public API change, module interface etc), add a label for "needs docs" and inform the submitter they must submit a docs PR to update the appropriate area of Prebid.org **before the PR can merge**. Help them with finding where the docs are located on prebid.org if needed.
- If all above is good, add a `LGTM` comment and, if the change is in PBS-core or is an important module like the prebidServerBidAdapter, request 1 additional core member to review.
- Once there are 2 `LGTM` on the PR, merge to master
- Add a line into the [draft release](https://github.com/prebid/Prebid.js/releases) notes for this submission. If no draft release is available, create one using [this template]( https://gist.github.com/mkendall07/c3af6f4691bed8a46738b3675cb5a479)
- The [draft release](https://github.com/prebid/Prebid.js/releases) notes are managed by [release drafter](https://github.com/release-drafter/release-drafter). To get the PR added to the release notes do the steps below. A github action will use that information to build the release notes.
- Adjust the PR Title to be appropriate for release notes
- Add a label for `feature`, `maintenance`, `fix`, `bugfix` or `bug` to categorize the PR
- Add a semver label of `major`, `minor` or `patch` to indicate the scope of change

### Reviewing a New or Updated Bid Adapter
Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/bidder-adaptor.html
Expand Down
83 changes: 41 additions & 42 deletions RELEASE_SCHEDULE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
**Table of Contents**
- [Release Schedule](#release-schedule)
- [Release Process](#release-process)
- [1. Make sure that all PRs have been named and labeled properly per the PR Process](#1-make-sure-that-all-prs-have-been-named-and-labeled-properly-per-the-pr-process)
- [2. Make sure all browserstack tests are passing](#2-make-sure-all-browserstack-tests-are-passing)
- [3. Prepare Prebid Code](#3-prepare-prebid-code)
- [4. Verify the Release](#4-verify-the-release)
- [5. Create a GitHub release](#5-create-a-github-release)
- [6. Update coveralls _(skip for legacy)_](#6-update-coveralls-skip-for-legacy)
- [7. Distribute the code](#7-distribute-the-code)
- [8. Increment Version for Next Release](#8-increment-version-for-next-release)
- [Beta Releases](#beta-releases)
- [FAQs](#faqs)

Expand All @@ -9,7 +17,7 @@
We aim to push a new release of Prebid.js every week on Tuesday.

While the releases will be available immediately for those using direct Git access,
it will be about a week before the Prebid Org [Download Page](http://prebid.org/download.html) will be updated.
it will be about a week before the Prebid Org [Download Page](http://prebid.org/download.html) will be updated.

You can determine what is in a given build using the [releases page](https://github.com/prebid/Prebid.js/releases)

Expand All @@ -19,14 +27,20 @@ Announcements regarding releases will be made to the #headerbidding-dev channel

_Note: If `github.com/prebid/Prebid.js` is not configured as the git origin for your repo, all of the following git commands will have to be modified to reference the proper remote (e.g. `upstream`)_

1. Make Sure all browserstack tests are passing. On PR merge to master CircleCI will run unit tests on browserstack. Checking the last CircleCI build [here](https://circleci.com/gh/prebid/Prebid.js) for master branch will show you detailed results.

In case of failure do following,
### 1. Make sure that all PRs have been named and labeled properly per the [PR Process](https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md#general-pr-review-process)
* Do this by checking the latest draft release from the [releases page](https://github.com/prebid/Prebid.js/releases) and make sure nothing appears in the first section called "In This Release". If they do, please open the PRs and add the appropriate labels.
* Do a quick check that all the titles/descriptions look ok, and if not, adjust the PR title.

### 2. Make sure all browserstack tests are passing

On PR merge to master, CircleCI will run unit tests on browserstack. Checking the last CircleCI build [here](https://circleci.com/gh/prebid/Prebid.js) for master branch will show you detailed results.**

In case of failure do following,
- Try to fix the failing tests.
- If you are not able to fix tests in time. Skip the test, create issue and tag contributor.

#### How to run tests in browserstack
**How to run tests in browserstack**

_Note: the following browserstack information is only relevant for debugging purposes, if you will not be debugging then it can be skipped._

Set the environment variables. You may want to add these to your `~/.bashrc` for convenience.
Expand All @@ -35,40 +49,40 @@ _Note: If `github.com/prebid/Prebid.js` is not configured as the git origin for
export BROWSERSTACK_USERNAME="my browserstack username"
export BROWSERSTACK_ACCESS_KEY="my browserstack access key"
```

```
gulp test --browserstack >> prebid_test.log
vim prebid_test.log // Will show the test results
```


2. Prepare Prebid Code
### 3. Prepare Prebid Code

Update the package.json version to become the current release. Then commit your changes.

```
git commit -m "Prebid 1.x.x Release"
git commit -m "Prebid 4.x.x Release"
git push
```

3. Verify Release
### 4. Verify the Release

Make sure your there are no more merges to master branch. Prebid code is clean and up to date.

4. Create a GitHub release
### 5. Create a GitHub release

Edit the most recent [release notes](https://github.com/prebid/Prebid.js/releases) draft and make sure the correct version is set and the master branch is selected in the dropdown. Click `Publish release`. GitHub will create release tag.

Edit the most recent [release notes](https://github.com/prebid/Prebid.js/releases) draft and make sure the correct tag is in the dropdown. Click `Publish`. GitHub will create release tag.

Pull these changes locally by running command
Pull these changes locally by running command
```
git pull
git fetch --tags
```
```

and verify the tag.

5. Update coveralls _(skip for legacy)_
### 6. Update coveralls _(skip for legacy)_

We use https://coveralls.io/ to show parts of code covered by unit tests.

Expand All @@ -80,35 +94,23 @@ _Note: If `github.com/prebid/Prebid.js` is not configured as the git origin for

Run `gulp coveralls` to update code coverage history.

6. Distribute the code
### 7. Distribute the code

_Note: do not go to step 7 until step 6 has been verified completed._
_Note: do not go to step 8 until step 7 has been verified completed._

Reach out to any of the Appnexus folks to trigger the jenkins job.

// TODO
// TODO:
Jenkins job is moving files to appnexus cdn, pushing prebid.js to npm, purging cache and sending notification to slack.
Move all the files from Appnexus CDN to jsDelivr and create bash script to do above tasks.

7. Post Release Version

Update the version
Manually edit Prebid's package.json to become "1.x.x-pre" (using the values for the next release). Then commit your changes.
### 8. Increment Version for Next Release

Update the version by manually editing Prebid's `package.json` to become "4.x.x-pre" (using the values for the next release). Then commit your changes.
```
git commit -m "Increment pre version"
git push
```

8. Create new release draft

Go to [github releases](https://github.com/prebid/Prebid.js/releases) and add a new draft for the next version of Prebid.js with the following template:
```
## 🚀New Features
## 🛠Maintenance
## 🐛Bug Fixes
```

## Beta Releases

Expand All @@ -129,11 +131,8 @@ Characteristics of a `GA` release:
## FAQs

**1. Is there flexibility in the schedule?**

If a major bug is found in the current release, a maintenance patch will be done as soon as possible.

It is unlikely that we will put out a maintenance patch at the request of a given bid adapter or module owner.
* If a major bug is found in the current release, a maintenance patch will be done as soon as possible.
* It is unlikely that we will put out a maintenance patch at the request of a given bid adapter or module owner.

**2. What Pull Requests make it into a release?**

Every PR that's merged into master will be part of a release. Here are the [PR review guidelines](https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md).
* Every PR that's merged into master will be part of a release. Here are the [PR review guidelines](https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md).
20 changes: 19 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,28 @@ function viewCoverage(done) {
connect.server({
port: coveragePort,
root: 'build/coverage/lcov-report',
livereload: false
livereload: false,
debug: true
});
opens('http://' + mylocalhost + ':' + coveragePort);
done();
};

viewCoverage.displayName = 'view-coverage';

// View the reviewer tools page
function viewReview(done) {
var mylocalhost = (argv.host) ? argv.host : 'localhost';
var reviewUrl = 'http://' + mylocalhost + ':' + port + '/integrationExamples/reviewerTools/index.html'; // reuse the main port from 9999

// console.log(`stdout: opening` + reviewUrl);

opens(reviewUrl);
done();
};

viewReview.displayName = 'view-review';

// Watch Task with Live Reload
function watch(done) {
var connect = require('gulp-connect');
Expand Down Expand Up @@ -434,4 +448,8 @@ gulp.task('e2e-test', gulp.series(clean, setupE2e, gulp.parallel('build-bundle-p
gulp.task(bundleToStdout);
gulp.task('bundle', gulpBundle.bind(null, false)); // used for just concatenating pre-built files with no build step

// build task for reviewers, runs test-coverage, serves, without watching
gulp.task(viewReview);
gulp.task('review-start', gulp.series(clean, lint, gulp.parallel('build-bundle-dev', watch, testCoverage), viewReview));

module.exports = nodeBundle;
Loading

0 comments on commit a5226d8

Please sign in to comment.