Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade pubmatic adapter version to support digitrust changes in open… #279

Merged
merged 2 commits into from
Dec 10, 2018
Merged

upgrade pubmatic adapter version to support digitrust changes in open… #279

merged 2 commits into from
Dec 10, 2018

Conversation

pm-manasi-moghe
Copy link
Collaborator

@pm-manasi-moghe pm-manasi-moghe commented Nov 29, 2018 •
edited
Loading

Type of change

  • [x ] Other

Description of change

Updated pubmatic bid adapter in openwrap to latest prebid version to support digitrust changes.

  • contact email of the adapter’s maintainer
  • official adapter submission

@pm-harshad-mane
Copy link
Collaborator

Hello @pm-manasi-moghe ,
Kindly update the description part of the PR.
We need to merge the update unit test case of the PubMatic adapter
I see that we are not picking the update in core prebid where Prebid makes sure it sends a copy of the adUnits object to every adapter to avoid object manipulations.

@pm-harshad-mane
Copy link
Collaborator

LGTM.
Please update the description of the PR.

@PubMatic-OpenWrap PubMatic-OpenWrap merged commit f4a27e0 into nightly Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-manasi-moghe @pm-harshad-mane @PubMatic-OpenWrap