forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Updated KGPV and different Bid Id #443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UOE-5870] Behaviour discrepancy of slotid/bidid used in dfp call and logger & tracker calls
5930: assigned adId as bidId instead of requestId
Changed netRevenue from false to true
pm-shashank-jain
added a commit
that referenced
this pull request
Jan 27, 2021
* Updated the bidId to real-time generated one, which is used by Logger and Tracker * Updating bidId for tracker and logger call * 5930: assigned adId as bidId instead of requestId * KGPV For Video * Fix for KGPSV Video in instream video * Fix an issue in case of no bid * Changed netRevenue from false to true Co-authored-by: Azhar <azhar@L1119.local> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com> Co-authored-by: Azhar <azhar@L1119.local> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com>
pm-shashank-jain
added a commit
that referenced
this pull request
Feb 10, 2021
* Fix for Updated KGPV and different Bid Id (#443) * Updated the bidId to real-time generated one, which is used by Logger and Tracker * Updating bidId for tracker and logger call * 5930: assigned adId as bidId instead of requestId * KGPV For Video * Fix for KGPSV Video in instream video * Fix an issue in case of no bid * Changed netRevenue from false to true Co-authored-by: Azhar <azhar@L1119.local> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com> * send ab test parameter to pubmatic server Co-authored-by: Azhar <azhar@L1119.local> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.