Between: Fix for bid floor issue#1787 (prebid#1870)

Co-authored-by: Egor Skorokhodov <skorokhodov@betweenx.com>
PubMatic-OpenWrap · Aug 2, 2021 · 2a64ed2 · 2a64ed2
1 parent 28025d4
commit 2a64ed2
Show file tree

Hide file tree

Showing 11 changed files with 8 additions and 45 deletions.
diff --git a/adapters/between/between.go b/adapters/between/between.go
@@ -20,10 +20,6 @@ type BetweenAdapter struct {
 	EndpointTemplate template.Template
 }
 
-// BetweenSSP requires bidfloor > 0.
-// If BidFloor of openrtb_ext.ExtImpBetween is zero, set it to defaultBidFloor value, see addImpProps
-const defaultBidfloor = 0.00001
-
 func (a *BetweenAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
 	var errors []error
 	if len(request.Imp) == 0 {
@@ -129,14 +125,6 @@ func buildImpBanner(imp *openrtb2.Imp) error {
 // Add Between required properties to Imp object
 func addImpProps(imp *openrtb2.Imp, secure *int8, betweenExt *openrtb_ext.ExtImpBetween) {
 	imp.Secure = secure
-	if betweenExt.BidFloor <= 0 {
-		imp.BidFloor = defaultBidfloor
-	} else {
-		imp.BidFloor = betweenExt.BidFloor
-	}
-	if betweenExt.BidFloorCur != "" {
-		imp.BidFloorCur = betweenExt.BidFloorCur
-	}
 }
 
 // Adding header fields to request header

diff --git a/adapters/between/betweentest/exemplary/multi-request.json b/adapters/between/betweentest/exemplary/multi-request.json
@@ -71,7 +71,6 @@
                   "publisher_id": "1"
                 }
               },
-              "bidfloor": 1e-05,
               "secure": 0
             },
             {
@@ -92,7 +91,6 @@
                   "publisher_id": "1"
                 }
               },
-              "bidfloor": 1e-05,
               "secure": 0
             }
           ],

diff --git a/adapters/between/betweentest/exemplary/secure-detect.json b/adapters/between/betweentest/exemplary/secure-detect.json
@@ -46,7 +46,6 @@
                   "w": 728,
                   "h": 90
                 },
-                "bidfloor": 1e-05,
                 "secure": 1,
                 "ext": {
                   "bidder": {

diff --git a/adapters/between/betweentest/exemplary/simple-site-banner.json b/adapters/between/betweentest/exemplary/simple-site-banner.json
@@ -21,9 +21,7 @@
         "ext": {
           "bidder": {
             "host": "127.0.0.1",
-            "publisher_id": "1",
-            "bid_floor_cur": "RUB",
-            "bid_floor": 1000
+            "publisher_id": "1"
           }
         }
       }
@@ -48,15 +46,11 @@
                 "w": 728,
                 "h": 90
               },
-              "bidfloor": 1000,
-              "bidfloorcur": "RUB",
               "secure": 0,
               "ext": {
                 "bidder": {
                   "host": "127.0.0.1",
-                  "publisher_id": "1",
-                  "bid_floor_cur": "RUB",
-                  "bid_floor": 1000
+                  "publisher_id": "1"
                 }
               }
             }

diff --git a/adapters/between/betweentest/supplemental/bad-dsp-request-example.json b/adapters/between/betweentest/supplemental/bad-dsp-request-example.json
@@ -46,7 +46,6 @@
                 "w": 728,
                 "h": 90
               },
-              "bidfloor": 1e-05,
               "secure": 0,
               "ext": {
                 "bidder": {

diff --git a/adapters/between/betweentest/supplemental/bad-response-body.json b/adapters/between/betweentest/supplemental/bad-response-body.json
@@ -42,7 +42,6 @@
                 "w": 300,
                 "h": 250
               },
-              "bidfloor": 1e-05,
               "secure": 0,
               "ext": {
                 "bidder": {

diff --git a/adapters/between/betweentest/supplemental/dsp-server-internal-error-example.json b/adapters/between/betweentest/supplemental/dsp-server-internal-error-example.json
@@ -46,7 +46,6 @@
                 "w": 728,
                 "h": 90
               },
-              "bidfloor": 1e-05,
               "secure": 0,
               "ext": {
                 "bidder": {

diff --git a/adapters/between/betweentest/supplemental/no-bids.json b/adapters/between/betweentest/supplemental/no-bids.json
@@ -46,7 +46,6 @@
                 "w": 728,
                 "h": 90
               },
-              "bidfloor": 1e-05,
               "secure": 0,
               "ext": {
                 "bidder": {

diff --git a/adapters/between/params_test.go b/adapters/between/params_test.go
@@ -41,16 +41,15 @@ func TestInvalidParams(t *testing.T) {
 
 var validParams = []string{
 	`{"host":"lbs-eu1.ads", "publisher_id": "1"}`,
-	`{"host":"lbs-eu1.ads", "publisher_id": "1", "bid_floor": 5.5}`,
-	`{"host":"lbs-eu1.ads", "publisher_id": "1", "bid_floor": 1, "bid_floor_cur": "RUB"}`,
+	`{"host":"lbs-ru1.ads", "publisher_id": "2"}`,
+	`{"host":"lbs-us-east1.ads", "publisher_id": "3"}`,
+	`{"host":"lbs-asia1.ads", "publisher_id": "4"}`,
 }
 
 var invalidParams = []string{
 	`{"host":"badhost.ads", "publisher_id": "1"}`,
 	`{"host":"lbs-eu1.ads", "publisher_id": 1}`,
-	`{"host":"lbs-eu1.ads", "publisher_id": "1"", "bid_floor": 5.5}`,
-	`{"host":"lbs-eu1.ads", "publisher_id": "1", "bid_floor": "5.5"}`,
-	`{"host":"lbs-eu1.ads", "publisher_id": "1", "bid_floor": 5.5, "bid_floor_cur": "cur"}`,
+	`{"host":"lbs-eu1.ads", "publisher_id": "1""}`,
 	``,
 	`null`,
 	`true`,

diff --git a/openrtb_ext/imp_between.go b/openrtb_ext/imp_between.go
@@ -1,8 +1,6 @@
 package openrtb_ext
 
 type ExtImpBetween struct {
-	Host        string  `json:"host"`
-	PublisherID string  `json:"publisher_id"`
-	BidFloor    float64 `json:"bid_floor"`
-	BidFloorCur string  `json:"bid_floor_cur"`
+	Host        string `json:"host"`
+	PublisherID string `json:"publisher_id"`
 }
diff --git a/static/bidder-params/between.json b/static/bidder-params/between.json
@@ -12,15 +12,6 @@
     "publisher_id": {
       "type": "string",
       "description": "Publisher ID from Between Exchange control panel"
-    },
-    "bid_floor": {
-      "type": "number",
-      "description": "The minimum price acceptable for a bid"
-    },
-    "bid_floor_cur": {
-      "type": "string",
-      "description": "Currency of bid floor",
-      "enum": ["USD", "EUR", "RUB"]
     }
   },
   "required": ["host", "publisher_id"]