Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .nvmrc file with correct Node Version #195

Closed
3 tasks
seyilonge-ps opened this issue Aug 9, 2024 · 1 comment · Fixed by #215
Closed
3 tasks

Update .nvmrc file with correct Node Version #195

seyilonge-ps opened this issue Aug 9, 2024 · 1 comment · Fixed by #215
Assignees
@seyilonge-ps
Labels
internal development Not user-facing work - developer experience

Comments

@seyilonge-ps
Copy link
Collaborator

seyilonge-ps commented Aug 9, 2024 •
edited
Loading

The Node version in the .nvmrc file shows 20.4.0 while the README.md file has 20.11.0. Running nvm use followed by npm clean-install results in errors.

Running nvm list provides a list of Node versions shown below
Screenshot 2024-08-09 at 10 56 21 AM

Version 20.11.0 in the README.md file is not listed. Best to use the most recent version in the list closest to the one specified in the README.md file, which is version 20.15.0.

Steps to fix:

  • Update Node version specified in the .nvmrc file to 20.15.0
  • Update Node version in the README.md file to 20.15.0
  • Add unit test to ensure the node version in the README.md matches the one in the .nvmrc
@seyilonge-ps seyilonge-ps added the internal development Not user-facing work - developer experience label Aug 9, 2024
@zoltan-dulac
Copy link
Collaborator

Can you add to the steps to fix "Make unit test to ensure the node version in the README matches the one in the .nvmrc? I'm sure this will happen again if we don't fix this.

Thanks for finding this and opening a ticket for it.

@seyilonge-ps seyilonge-ps self-assigned this Aug 9, 2024
seyilonge-ps pushed a commit that referenced this issue Aug 23, 2024
(#195) Update .nvmrc file with correct Node Version
2b737fe 
* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
seyilonge-ps pushed a commit that referenced this issue Aug 23, 2024
(#195) Update .nvmrc file with correct Node Version
1d74e48 
* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
seyilonge-ps pushed a commit that referenced this issue Aug 23, 2024
(#195) Update .nvmrc file with correct Node Version
145943b 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
seyilonge-ps pushed a commit that referenced this issue Aug 23, 2024
(#195) Update .nvmrc file with correct Node Version
7b853da 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
* Updated Node version for GitHub actions
@seyilonge-ps seyilonge-ps linked a pull request Aug 26, 2024 that will close this issue
(#195) Update .nvmrc file with correct Node Version #215
Merged
seyilonge-ps pushed a commit that referenced this issue Sep 3, 2024
(#195) Update .nvmrc file with correct Node Version
1759ae7 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
* Updated Node version for GitHub actions
* Updated `README.md` file `Setup` section
* Added validation script file
seyilonge-ps pushed a commit that referenced this issue Sep 3, 2024
(#195) Update .nvmrc file with correct Node Version
4c06dfc 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
* Updated Node version for GitHub actions
* Updated `README.md` file `Setup` section
* Added validation script file
seyilonge-ps pushed a commit that referenced this issue Sep 5, 2024
(#195) Update .nvmrc file with correct Node Version
71a3e02 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
* Updated Node version for GitHub actions
* Updated `README.md` file `Setup` section
* Added validation script file
* Removed `console.log` from test files
* Added `chromedriver_force_download=true` to `.npmrc` file
* Updated `chromedriver` from version `126.0.4` to `128.0.1`
* Removed `git add` task from `lint-staged` run script
seyilonge-ps pushed a commit that referenced this issue Sep 5, 2024
(#195) Update .nvmrc file with correct Node Version
63d10e2 
Closes #195

* Updated `.nvmrc` and `README.md` files with correct Node version
* Added `engines` property to `package.json` to specify Node and npm version ranges
* Added `.npmrc` file and set `engine-strict` property to `true`
* Updated Node version for GitHub actions
* Updated `README.md` file `Setup` section
* Added validation script file
* Removed `console.log` from test files
* Added `chromedriver_force_download=true` to `.npmrc` file
* Updated `chromedriver` from version `126.0.4` to `128.0.1`
* Removed `git add` task from `lint-staged` run script
* Updated chrome browser version for download in github `push-actions.yml` file
zoltan-dulac added a commit that referenced this issue Sep 9, 2024
@zoltan-dulac
Merge pull request #215 from PublicisSapient/ticket/195-update-files-…
d0a9384 
…with-correct-node-version

(#195) Update .nvmrc file with correct Node Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seyilonge-ps seyilonge-ps

Labels
internal development Not user-facing work - developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#195) Update .nvmrc file with correct Node Version PublicisSapient/enable-a11y
2 participants
@zoltan-dulac @seyilonge-ps