Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: adding necessary changes to view as dark mode #127

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

basiabaldwin
Copy link
Collaborator

While the code I created does appear as dark mode (when these specific elements are changed in index.css), the code is not actually differentiating between light/dark mode (yet). Just doing this pull request so you can review how I did the changes. If you run the code currently, it will appear normally (light mode) but I attached screenshots of what the webpage looks like when the dark mode values would be used so you can compare it to the current webpage!

enable_dark1 enable_dark2 enable_dark3

css/index.css Outdated Show resolved Hide resolved
@basiabaldwin
Copy link
Collaborator Author

Just adding a note that after adding changes to .less rather than .css, dark mode change is appearing now for index! Will continue working on changes for rest of pages.

@basiabaldwin basiabaldwin changed the title added to index.css necessary changes to view as dark mode -- PR just for review not to merge! adding necessary changes to view as dark mode Jun 12, 2024
Copy link
Collaborator

@zoltan-dulac zoltan-dulac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things. Just to be clear: has the whole site been checked under dark mode? Let me know. If not, we should still have the title of this PR have a prefix of "WIP:"

less/dropdown.less Outdated Show resolved Hide resolved
@basiabaldwin basiabaldwin changed the title adding necessary changes to view as dark mode WIP: adding necessary changes to view as dark mode Jun 26, 2024
Copy link
Collaborator

@zoltan-dulac zoltan-dulac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please look at the feedback here to ensure all the tasks are done?

Imran-imtiaz48

This comment was marked as spam.

@basiabaldwin

This comment was marked as outdated.

Copy link
Collaborator Author

@basiabaldwin basiabaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed all changes and comments to ensure code is correct

Copy link
Collaborator

@zoltan-dulac zoltan-dulac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on our last call, check all styling for contrast issues. I want to make sure the dark mode is as accessible as light mode.

That goes for text as well as graphical elements (e.g. box borders).

Copy link
Collaborator Author

@basiabaldwin basiabaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed awhile ago

@basiabaldwin
Copy link
Collaborator Author

Hi @zoltan-dulac , there is a change request on July 11 that I cannot dismiss and in turn it is blocking the merge. Wanted to see if it could be dismissed on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants