-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: adding necessary changes to view as dark mode #127
base: main
Are you sure you want to change the base?
Conversation
Just adding a note that after adding changes to .less rather than .css, dark mode change is appearing now for index! Will continue working on changes for rest of pages. |
…o go in a make sure all components change but this is a good start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things. Just to be clear: has the whole site been checked under dark mode? Let me know. If not, we should still have the title of this PR have a prefix of "WIP:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please look at the feedback here to ensure all the tasks are done?
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed all changes and comments to ensure code is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on our last call, check all styling for contrast issues. I want to make sure the dark mode is as accessible as light mode.
That goes for text as well as graphical elements (e.g. box borders).
Signed-off-by: Basia Baldwin <35499120+basiabaldwin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed awhile ago
Hi @zoltan-dulac , there is a change request on July 11 that I cannot dismiss and in turn it is blocking the merge. Wanted to see if it could be dismissed on your end. |
…e-a11y into dark-mode
…enable-a11y into dark-mode
While the code I created does appear as dark mode (when these specific elements are changed in index.css), the code is not actually differentiating between light/dark mode (yet). Just doing this pull request so you can review how I did the changes. If you run the code currently, it will appear normally (light mode) but I attached screenshots of what the webpage looks like when the dark mode values would be used so you can compare it to the current webpage!