Made RTD endpoint optional. Read the floors from local storage if the dynamic endpoint is not provided. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dynamic endpoint is not provided.
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Nikhil-X
reviewed
Jul 26, 2024
modules/pubxaiRtdProvider.js
Outdated
| } else { | ||
| // Fetch from local storage | ||
| try { | ||
| const localData = storage.getDataFromLocalStorage('pubx:dynamicFloors') || window.__pubxDynamicFloors__; |
There was a problem hiding this comment.
This data is written to localStorage by RTD module or will be written by the external floors loading script?
Nikhil-X
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Providing RTD endpoint param is optional now. In case of missing RTD endpoint, it tries to read the required data either from local storage or from global variables.