Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #427

Closed
wants to merge 1 commit into from

Conversation

noah-de
Copy link

@noah-de noah-de commented Sep 3, 2022

Otherwise new comers who want to follow along would see something like this:
'go get' is no longer supported outside a module.
To build and install a command, use 'go install' with a version,
like 'go install example.com/cmd@latest'
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.

Otherwise new comers who want to follow along would see something like this:
        'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
@mna
Copy link
Member

mna commented Sep 3, 2022

go install with the version specifier is to install commands (executables). Goquery is a package, go get is the right way to install it, it's just that you now have to be in a Go module to install it. I'd welcome a PR that makes that clearer.

@noah-de noah-de closed this Sep 3, 2022
@noah-de
Copy link
Author

noah-de commented Sep 3, 2022

Thanks for the kind reply.
I am still getting used to how things work in Go, (recognizing a project's purpose via the structure of the source code).

Now I see that Goquery is a package installed (as a source based dependency) and then imported into code.
The documentation does a pretty good job of showing that.
I was aware of the official discussion, golang/go#40276 but am still new enough to the language that I misunderstood the meaning, until now.

Many thanks!

@noah-de noah-de reopened this Sep 3, 2022
@noah-de noah-de closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants