Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent registry values and player changes #324

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

Alvsch
Copy link
Contributor

@Alvsch Alvsch commented Nov 21, 2024

Description

  • Now using IndexMap instead of HashMap for registry values so they have consistent ordering between runtime.
  • player.world() can now be used instead of &player.living_entity.entity.world.
  • Moved player.respawn() to world.respawn_player() as spawn_player is on world. (might reconsider)
  • Preperations for multi-world support where the registry is involved.

Testing

  • same biome every time
  • no spawning in the ground
  • multiple players work as before

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy

@Commandcracker Commandcracker mentioned this pull request Nov 23, 2024
2 tasks
@Snowiiii
Copy link
Member

LGTM.
Thanks @Alvsch

@Snowiiii Snowiiii merged commit c3c4aff into Pumpkin-MC:master Nov 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants