Add multi noise biome source #445
Conversation
| } | ||
|
|
||
| pub struct MultiNoiseSampler { | ||
| pub(crate) temperature: Box<dyn ComponentReference<NoEnvironment>>, |
There was a problem hiding this comment.
This can be a shared or mutable component reference depending on what is needed, if no environment is needed, they can probably be SharedComponentReference and then you can call sample instead of sample_mut
| @@ -59,3 +59,4 @@ uuid = { version = "1.11.0", features = ["serde", "v3", "v4"] } | |||
| derive_more = { version = "1.0.0", features = ["full"] } | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| serde_with = "3.12" | |||
There was a problem hiding this comment.
Why this was added ?, And is there a way to get the same done without this ?
There was a problem hiding this comment.
it was added to serialize {"key":value} as Vec<(Key,Value)>, i can change the format of the data in extractor to be an array
There was a problem hiding this comment.
Having a library less seems better
|
@urisinger any progress on this one ? |
I've been busy the past few days, I'll pick it up next week |
|
I think it might be time to officially update it now?I'm really looking forward to the implementation of this feature. 我觉得或许现在正是更新它的时候？我非常期待这个功能的实现。 |
|
Sorry for the delay, I'll start working on it again today, I have some changes regarding the general biome generator to finish then I can merge the full biome list that was added and implement it. Then I'll start working on generating each biome in a separate pr |
Oh wow,this could be a great PR. |
Description
this pr adds MultiNoiseBiomeSource and BiomeEntries to generate biomes, which is supposed to mimic MultiNoiseUtil and MultiNoiseBiomeSource.
Testing
not yet
Please follow our Coding Guidelines