refactor: fx bridge logic eth

[zakir-code]

Summary by CodeRabbit

• New Features

  • Enhanced FxBridgeLogicETH contract with new data and memo fields replacing the message field for better data handling and clarity in bridge transactions.
  • Improved validation checks in transaction functions to ensure non-empty tokens or data are processed.

• Refactor

  • Removed gasLimit field and related parameters across various functions in the FxBridgeLogicETH contract to streamline operations.
  • Reordered parameters in several functions to accommodate new changes and improve usability.

• Bug Fixes

  • Added validation in the _transferERC20 function to ensure matching tokens and amounts, preventing mismatch errors.

• Chores

  • Removed bridgeCallbackV1 function in IBridgeCallback interface to simplify callback handling.

[coderabbitai]

Walkthrough

The updates to the Solidity contracts focus on refining data handling and parameter usage across functions, particularly in the FxBridgeLogicETH and IBridgeCallback files. Changes include the removal of gasLimit, addition of data and memo fields, and enhanced validation for token-data consistency.

Changes

Files	Changes
.../bridge/FxBridgeLogicETH.sol	Updated BridgeCallData struct, modified functions (bridgeCall, submitBridgeCall, calculateMessageHash, verifyBridgeCall), added checks in _transferERC20, and updated event parameters.
.../bridge/IBridgeCallback.sol	Removed bridgeCallbackV1 function.

🐇🌟
In the land of code and myth,
Changes swift as rabbit's hop,
Fields and checks, neatly swapped,
Data flows without a stop.
Cheers to code that leaps non-stop! 🚀🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fx0x55]

@coderabbitai review

[coderabbitai]

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[fx0x55]

mg