Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: EmitEvent is used for a single event #482

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

zakir-code
Copy link
Contributor

@zakir-code zakir-code commented May 15, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Corrected event emission methods to ensure consistent and accurate event logging across various functionalities, including bridge calls, delegate additions, share transfers, and IBC calls.

Copy link

coderabbitai bot commented May 15, 2024

Walkthrough

The recent update focuses on standardizing the event emission method across various modules by replacing the EmitEvents method with the EmitEvent method. This change simplifies the event emission process, ensuring consistency and potentially improving performance. The update spans multiple files, including those related to cross-chain operations, message handling, EVM precompiles, and IBC calls.

Changes

Files Change Summary
x/crosschain/keeper/bridge_call_in.go Changed EmitEvents to EmitEvent in BridgeCallEvm function.
x/crosschain/keeper/msg_server.go Changed EmitEvents to EmitEvent in AddDelegate method.
x/evm/precompiles/staking/transfer_shares.go Changed EmitEvents to EmitEvent in TransferShares, TransferFromShares, and TransferSharesEmitEvents functions.
x/ibc/applications/transfer/keeper/ibc_call.go Changed EmitEvents to EmitEvent in HandlerIbcCallEvm function.

🐇
In code so fine, events now flow,
From EmitEvents to EmitEvent they go.
Across the chains, messages clear,
Simplicity and grace draw near.
With each byte and every call,
Consistency stands tall. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zakir-code
Copy link
Contributor Author

mg

@zakir-code zakir-code merged commit f4de51a into main May 15, 2024
9 checks passed
@zakir-code zakir-code deleted the zakir/event branch May 15, 2024 06:45
zakir-code added a commit to zakir-code/fx-core that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant