refactor: rename MsgBridgeCall OutgoingBridgeCall receiver to refund #525
Conversation
WalkthroughThe changes focus on renaming the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
x/crosschain/types/tx.pb.gois excluded by!**/*.pb.gox/crosschain/types/types.pb.gois excluded by!**/*.pb.go
Files selected for processing (16)
- proto/fx/crosschain/v1/tx.proto (1 hunks)
- proto/fx/crosschain/v1/types.proto (1 hunks)
- x/crosschain/client/cli/flags.go (1 hunks)
- x/crosschain/client/cli/tx.go (2 hunks)
- x/crosschain/keeper/bridge_call_out.go (2 hunks)
- x/crosschain/keeper/bridge_call_out_test.go (1 hunks)
- x/crosschain/keeper/bridge_call_refund.go (2 hunks)
- x/crosschain/keeper/bridge_call_refund_test.go (1 hunks)
- x/crosschain/keeper/msg_server.go (1 hunks)
- x/crosschain/tests/bridge_call_out_test.go (2 hunks)
- x/crosschain/tests/msg_server_test.go (1 hunks)
- x/crosschain/types/msgs.go (2 hunks)
- x/crosschain/types/msgs_test.go (4 hunks)
- x/crosschain/types/types.go (1 hunks)
- x/crosschain/types/types_test.go (1 hunks)
- x/tron/types/checkpoint.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/crosschain/keeper/bridge_call_out.go
Additional comments not posted (37)
x/crosschain/client/cli/flags.go (1)
1-5: Removal ofFlagToconstant aligns with the renaming strategy in the PR. Ensure all references to this flag are updated or removed in the codebase.x/crosschain/keeper/bridge_call_refund_test.go (1)
22-23: The test correctly initializes and uses the newRefundfield, aligning with the changes in the keeper functions.x/crosschain/keeper/bridge_call_refund.go (1)
15-16: The functionHandleOutgoingBridgeCallRefundcorrectly uses therefundaddress, and the logic remains consistent with the intended functionality. Ensure comprehensive testing to verify the behavior with the new field.Also applies to: 24-24, 42-42, 46-46
x/tron/types/checkpoint.go (1)
114-114: The inclusion of therefundaddress inGetCheckpointBridgeCallis consistent with the renaming strategy. Verify the correctness of the generated checkpoint to ensure it meets the expected format and values.x/crosschain/tests/bridge_call_out_test.go (1)
48-54: The test correctly initializes and uses the newRefundfield, aligning with the changes in the message handling functions.x/crosschain/keeper/bridge_call_out_test.go (1)
48-48: The test correctly initializes and uses the newRefundfield, aligning with the changes in the keeper functions.proto/fx/crosschain/v1/types.proto (1)
260-260: RenamingreceivertorefundinOutgoingBridgeCallaligns with the PR objectives.x/crosschain/types/types_test.go (1)
67-68: The test caseTestOutgoingBridgeCall_Checkpointcorrectly reflects the renaming ofreceivertorefund.proto/fx/crosschain/v1/tx.proto (1)
378-378: TheMsgBridgeCallmessage correctly updates thereceiverfield torefund.x/crosschain/client/cli/tx.go (1)
195-197: UpdatedCmdBridgeCallto includerefundparameter.Ensure that the
refundparameter is correctly documented and tested in associated unit tests.Also applies to: 205-217, 225-226
x/crosschain/types/types.go (1)
479-479: UpdatedGetCheckpointto includerefundparameter in the ABI encoding process.Ensure that the
refundparameter is correctly documented and tested in associated unit tests.x/crosschain/keeper/msg_server.go (1)
601-601: The renaming ofreceivertorefundin theBridgeCallfunction aligns with the PR objectives and is correctly implemented.x/crosschain/types/msgs.go (2)
718-718: RenamingreceivertorefundinMsgBridgeCallClaim.validateBasicaligns with the PR objectives and maintains the validation logic.
1184-1185: Conditionally validating therefundaddress inMsgBridgeCall.validateBasicbased on the presence ofCoinsis a logical change and aligns with the PR objectives.x/crosschain/tests/msg_server_test.go (13)
1334-1334: Ensure theRefundfield is correctly used in theMsgBridgeCalltest case.
Line range hint
10-133: The test cases inTestMsgBondedOracleare well-structured and cover a variety of scenarios.
Line range hint
135-235: The test cases inTestMsgAddDelegateeffectively validate the conditions under which delegation can occur, including proper error handling.
Line range hint
237-287: Comprehensive tests forMsgEditBridgerensure that the function behaves as expected under various conditions.
Line range hint
289-389: TheTestMsgSetOracleSetConfirmfunction thoroughly tests the oracle set confirmation process, including signature verification and error handling.
Line range hint
391-431: TheTestClaimWithOracleOnlinefunction correctly tests the claim process under the condition that the oracle is online, ensuring proper functionality.
Line range hint
433-533: TheTestClaimMsgGasConsumedfunction provides valuable insights into the gas consumption of various claim messages, ensuring efficiency.
Line range hint
535-585: TheTestClaimTestfunction effectively tests the claim functionality, including comprehensive error handling and successful processing.
Line range hint
587-687: TheTestRequestBatchBaseFeefunction provides important insights into how different base fee values affect the profitability and processing of request batches.
Line range hint
689-709: TheTestMsgUpdateChainOraclesfunction effectively tests the addition and removal of oracles, ensuring correct processing and state consistency.
Line range hint
711-761: TheTestBridgeCallClaimfunction effectively tests the bridge call claim functionality, including comprehensive error handling and successful processing.
Line range hint
763-813: TheTestMsgBridgeCallfunction effectively tests the processing of bridge calls, ensuring correct handling and state consistency.
Line range hint
815-865: TheTestAddPendingPoolRewardsfunction effectively tests the addition of rewards to the pending pool, including comprehensive error handling and successful addition.x/crosschain/types/msgs_test.go (10)
1949-1949: Ensure theRefundfield is correctly used in theMsgBridgeCallstruct.
1966-1966: TheRefundfield is correctly initialized in the test case setup.
1986-1986: TheRefundfield is correctly initialized in the test case setup for the error scenario.
1988-1988: TheTofield is correctly initialized in the test case setup for the error scenario.
2000-2000: TheRefundfield is correctly initialized in the test case setup for the error scenario.
2002-2002: TheTofield is correctly initialized in the test case setup for the error scenario.
2007-2007: The error scenario for an emptyRefundaddress is correctly handled.
2014-2014: TheRefundfield is correctly initialized in the test case setup for the error scenario.
2016-2016: TheTofield is correctly initialized in the test case setup for the error scenario.
2029-2029: TheRefundfield is correctly used in theMsgBridgeCallstruct.
|
mg |
Summary by CodeRabbit
receiverfield torefundacross various components and functions to improve clarity and consistency in handling refund addresses.CmdBridgeCallto reflect the new structure.