[PVP] Changes and fixes wave 2 #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dncer, ported the dancer partner remind over from pve without the autorotation stuff. added ev avant option to boost 1 2 combo damage with slider to save charges per user preference.
Fixed Logic so Fire resonance is always spent on phantom rush for the 18k hit. Otherwise it will be spent on wind's or flints reply when a second charge is available.
# Conflicts: # WrathCombo/Combos/PvE/BLM/BLM_Config.cs # WrathCombo/Combos/PvP/DNCPVP.cs
Wrath Rename support
Added the umbral ice check. Worked without but still needed cleanup. changed aetherial manip from charges to actionready
removed actionready. it wasnt needed
Mimiced the st changes on aoe button as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNC
ported the dancer partner remind over from pve without the autorotation stuff. added EnAvant option to boost 1 2 combo damage with slider to save charges per user preference.
BLM
Fixed the blizzard side trying to use foul. Not longer a pvp spell. Replaced with xeno as it intends
Fixed missing slider for wreath of ice health threshold.
Added wreath of fire execute mode option with slider. While it goes through guard, it is a lot of dps lost when it can have 50% uptime.
SAM
MNK
Fixed logic of fire resonance to always use it with phantom rush (largest hit of 12k) unless 2 charges are available and then throw one of a flints or winds reply (2nd largest hits of 8k but aoe)