Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRD] Cleanup and organization #131

Merged
merged 7 commits into from
Nov 30, 2024
Merged

[BRD] Cleanup and organization #131

merged 7 commits into from
Nov 30, 2024

Conversation

edewen
Copy link
Contributor

@edewen edewen commented Nov 26, 2024

TLDR. Basically a full and final cleaning of bards spaghetti. Inspired by zbees dancer code, set up regions and comments on sections so anyone can quickly read and troubleshoot issues in bard code. Lastly implemented Gakais dot management code across all features that need it as it cuts the section in half.

Fixed: Added delayed weave to low lvl song toggle to keep it from doubleweaving them together due to speed on autorotation.

Combo Preset Cleanup and Option ordering, Feature cleanup and organization.

  • Added Advanced slider information to simple description
  • Added job ID numbers to organize options in the settings, it was getting a bit unruly
  • Removed commented out settings leftover from sloth
  • Removed unused bools from heavy to straight-shot feature.
  • Set up regions to separate bard code into smaller features, advanced mode, simple mode
  • Moves st ogcd, bardbuffs, and bard aoecombo exactly as written up into the smaller features section
  • Changed the raging jaws refresh on simple st mode from 5 to 6 to be safe, its what Ive been using on advanced
  • Changed the nowaste on simple aoe to 5%, it always shoudl have been higher than 1.

Simple and Advanced Cleanup

  • Added Regions to match dancer code organization. ST and AOE
  • Removed needless Bools when a single action ready would suffice. ST and AOE
  • Left notes to make the code easy to understand at a glance. ST and AOE
  • Employed Gakai's Dot Management slimming it down significantly. ST
  • Slimmed Barrage logic, doesn't need to check all buffs when raging goes last anyway. ST and AOE
  • Moved Hawks eye logic above the other gcds with more time to fire them off. Hopefully fewer overwrites. ST and AOE
  • Put Interrupt in the middle of ogcd delayed weave to not block dps tools but still get a chance to happen. ST and AOE

Massive Cleanup. Ported Gakais dot management system into it. Added regions to be in line with dancer code.
@edewen edewen marked this pull request as draft November 27, 2024 04:49
regions, removed unneeded bools, Notated, wide volley logic moved up to match st. Slimmed down barrage logic.
Regions, bools, Comments, Moved interrupt, trimmed barrage logic
Cleaned up to match advance. Regions, bools, comments, moving interrupt, barrage logic trim, gakais dot management
@edewen edewen marked this pull request as ready for review November 27, 2024 22:29
Not sure why vs automatically added that shit. it wasnt needed
Under 52, automode too fast to recognize song started and is doubleweaving both. Put dleayed weave to buy it more time
@zbee zbee added the Optimization Similar to suggestion, but solely for increasing performance label Nov 30, 2024
@Taurenkey Taurenkey merged commit a4f9e2a into PunishXIV:main Nov 30, 2024
@edewen edewen deleted the Bard branch November 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Similar to suggestion, but solely for increasing performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants