Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRD] Fixes #161

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[BRD] Fixes #161

merged 3 commits into from
Dec 10, 2024

Conversation

edewen
Copy link
Contributor

@edewen edewen commented Dec 1, 2024 •
edited
Loading

  • Fixed level check on dot application logic in st, aoe, and ironjaws
  • Added bloodletter logic to aoe simple/adv ogcd below lvl 45 when you get rain of death
  • added logic to songs to allow automatic to play songs in 3 3 12 without a target for bosses with downtimes

@Akechi-kun Akechi-kun added Fixes This will fix a current issue Adjustments This will adjust something inside a rotation, feature, or core function labels Dec 3, 2024
@edewen edewen mentioned this pull request Dec 4, 2024
Closed
@edewen
Songs without targets
f9dd252 
Adjusted songs logic that without target in combat it will play songs and keep the 3 3 12 rotation and not screw over automatic players in fights with downtime
zbee
zbee approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@zbee zbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is primarily good, though I think it's worth mentioning some potential issues with logic regarding the downtime song maintenance.

WrathCombo/Combos/PvE/BRD/BRD.cs Show resolved Hide resolved
@Taurenkey Taurenkey merged commit b99502e into PunishXIV:main Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbee zbee zbee approved these changes

@Kagekazu Kagekazu Kagekazu approved these changes

Assignees
No one assigned
Labels
Adjustments This will adjust something inside a rotation, feature, or core function Fixes This will fix a current issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edewen @zbee @Kagekazu @Taurenkey @Akechi-kun