Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GNB/WAR/Bozja] fixes, adjustments, & new features #171

Merged
merged 24 commits into from
Dec 12, 2024

Conversation

Akechi-kun
Copy link
Contributor

@Akechi-kun Akechi-kun commented Dec 3, 2024

Kinda messy PR 😞 Sorry dad

Fixes

  • Fix issue with Burst Strike in opener
  • Fix issue with Hypervelocity inconsistently calling due to niche conditions (maybe)
  • Fix issue with Solid Barrel breaking combo due to niche conditions
  • Fix weaving issue with Gnashing Fang Features

Adjustments

  • Refactor Mitigation Options in Advanced modes for GNB
  • Refactor No Mercy Features & its options
  • Refactor Burst Strike Features & its options
  • Refactor Fated Circle Features & its options
  • Refactor WAR options (excluding Simple & Advanced modes)
  • Heavily clean up WAR
  • Remove GNB_Helper
    (NOTE: obsolete)

New Features

  • Add Mitigation Options in Advanced modes for WAR
  • Add Equilibrium Feature for WAR
  • Add more mitigation options for GNB
  • Add One-Button Mitigation Feature for GNB
  • Add One-Button Mitigation Feature for WAR
  • Implement Field Operations tab in PvEFeatures (props @zbee for guidance)
  • Add literally everything relating to Field Operations to prep for future implementations
    (NOTE: All actions, items, & status effects; see \PvE\Content\Bozja.cs for details)
  • Add Field Operations support for GNB
    (NOTE: see new Field Operations tab under GNB for these features; autorot untested)
    (TODO: refactor all this soon)
  • Add HP% sliders to all heal & mit based Lost Actions

@Akechi-kun Akechi-kun changed the title [GNB] even more 7.1 fixes/adjustments [GNB/WAR] even more 7.1 fixes/adjustments .. Mitigations additions Dec 3, 2024
@Akechi-kun Akechi-kun added Optimization Similar to suggestion, but solely for increasing performance New Feature This adds a new option or feature Fixes This will fix a current issue Adjustments This will adjust something inside a rotation, feature, or core function labels Dec 3, 2024
@Akechi-kun Akechi-kun changed the title [GNB/WAR] even more 7.1 fixes/adjustments .. Mitigations additions GNB more 7.1 fixes/adjustments .. WAR Mitigations .. Bozja prep Dec 4, 2024
@moreime
Copy link

moreime commented Dec 4, 2024

MY GOAT 🔥

@Akechi-kun Akechi-kun requested review from zbee and Taurenkey December 5, 2024 01:46
@Akechi-kun Akechi-kun mentioned this pull request Dec 5, 2024
13 tasks
@qnesp1987
Copy link

qnesp1987 commented Dec 7, 2024

advanced mode ST does not use bow shock / blasting zone at all. same for simple mode. they're only used in AoE it seems. No mercy is still used after 1st GCD in both modes as well.

@Akechi-kun Akechi-kun changed the title GNB more 7.1 fixes/adjustments .. WAR Mitigations .. Bozja prep [GNB/WAR/Bozja] fixes, adjustments, & new features Dec 8, 2024
Copy link
Member

@zbee zbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From just a cursory look at GNB and WAR changes: LGTM, I especially appreciated seeing all these Options changes seemingly without reusing IDs.

Regarding Bozja:
This all looks good, and some of it is still fresh from me helping with bits of it, but just taking the opportunity here to note some things still missing.

  • No other Field Operations would currently work, even if features were added as the Presets code does not even draw them.
    (not that there are other Field Operations currently added into the code yet)
  • This will not un-holster Lost Actions if needed.
    (perhaps this should be explicitly mentioned?) (fixed in 4bd6647)
  • This will not check amount-available for slotted Lost Actions. (fixed in 4bd6647)

Because of the last 2 items there, enabling more Lost Action options than just what the user actually has slotted leads to lots of actions just not being done.
Especially considering it is Bozja: I still think this is more than adequate for collecting feedback while the rest is worked out.

Copy link
Member

@Kagekazu Kagekazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been doing DT fates with GNB and WAR without any issues.

@Taurenkey Taurenkey merged commit 08130fc into PunishXIV:main Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjustments This will adjust something inside a rotation, feature, or core function Fixes This will fix a current issue New Feature This adds a new option or feature Optimization Similar to suggestion, but solely for increasing performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GNB] Skipping Burst Strike in opener, goes into NM right after keen edge
6 participants