-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GNB/WAR/Bozja] fixes, adjustments, & new features #171
Conversation
MY GOAT 🔥 |
advanced mode ST does not use bow shock / blasting zone at all. same for simple mode. they're only used in AoE it seems. No mercy is still used after 1st GCD in both modes as well. |
so much cleaner now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From just a cursory look at GNB and WAR changes: LGTM, I especially appreciated seeing all these Options changes seemingly without reusing IDs.
Regarding Bozja:
This all looks good, and some of it is still fresh from me helping with bits of it, but just taking the opportunity here to note some things still missing.
- No other Field Operations would currently work, even if features were added as the Presets code does not even draw them.
(not that there are other Field Operations currently added into the code yet) - This will not un-holster Lost Actions if needed.
(perhaps this should be explicitly mentioned?) (fixed in 4bd6647) - This will not check amount-available for slotted Lost Actions. (fixed in 4bd6647)
Because of the last 2 items there, enabling more Lost Action options than just what the user actually has slotted leads to lots of actions just not being done.
Especially considering it is Bozja: I still think this is more than adequate for collecting feedback while the rest is worked out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been doing DT fates with GNB and WAR without any issues.
Kinda messy PR 😞 Sorry dad
Fixes
Burst Strike
in openerHypervelocity
inconsistently calling due to niche conditions (maybe)Solid Barrel
breaking combo due to niche conditionsGnashing Fang Features
Adjustments
Mitigation Options
inAdvanced
modes forGNB
No Mercy Features
& its optionsBurst Strike Features
& its optionsFated Circle Features
& its optionsWAR
options (excludingSimple
&Advanced
modes)WAR
GNB_Helper
(NOTE: obsolete)
New Features
Mitigation Options
inAdvanced
modes forWAR
Equilibrium Feature
forWAR
GNB
One-Button Mitigation Feature
forGNB
One-Button Mitigation Feature
forWAR
Field Operations
tab inPvEFeatures
(props @zbee for guidance)Field Operations
to prep for future implementations(NOTE: All actions, items, & status effects; see
\PvE\Content\Bozja.cs
for details)Field Operations
support forGNB
(NOTE: see new
Field Operations
tab underGNB
for these features; autorot untested)(TODO: refactor all this soon)
Lost Actions