fix mir.ion error #297
Merged
fix mir.ion error #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-32603: mir.ion: non-optional member 'version_' in InitializeParamsClientInfo is missing.
|
This caused some issues for vim-lsp and coc.nvim (coc.nvim still doesn't work). |
WebFreak001
approved these changes
Jan 17, 2023
|
thanks, will add a check to avoid this happening with other types |
|
done: 5938adc maybe this helps with other LSP communication? (MarkdownClientCapabilities seems to be something that could have been broken before) |
|
Let me build and check. |
|
Maybe it helped some other lsp clients, but coc.nvim still not working. I have created issue earlier today on its issue tracker, maybe it would bring us somewhere too. Current logs is here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-32603: mir.ion: non-optional member 'version_' in InitializeParamsClientInfo is missing.