Workaround Compiler Bug in CI #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR an issue that was occurring in the GitHub Actions (https://github.com/PureSwift/Socket/actions/runs/11842311918). In CI environments, using [unowned self] was causing a compiler crash under specific conditions. As a workaround, the code has been updated to use [weak self] instead, preventing the crash.
example: https://github.com/lyrise/PureSwiftSocket/actions/runs/12567598902
What does this PR do?
Replaces [unowned self] with [weak self] to avoid a compiler crash in CI environments.
This change ensures stability in CI while the underlying issue is investigated.
Where should the reviewer start?
Review the change in the startMonitoring function in AsyncSocketManager.swift.