Merge pull request #1945 from chadf/fuzzing-2

Fixed division by zero due to thread race condition.
PurpleI2P · Jul 10, 2023 · 5142459 · 5142459
2 parents 8590dbd + 638e9b4
commit 5142459
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/libi2pd/NetDb.cpp b/libi2pd/NetDb.cpp
@@ -1253,7 +1253,9 @@ namespace data
 		uint16_t inds[3];
 		RAND_bytes ((uint8_t *)inds, sizeof (inds));
 		std::unique_lock<std::mutex> l(m_RouterInfosMutex);
-		inds[0] %= m_RouterInfos.size ();
+		auto count = m_RouterInfos.size ();
+		if(count == 0) return nullptr;
+		inds[0] %= count;
 		auto it = m_RouterInfos.begin ();
 		std::advance (it, inds[0]);
 		// try random router

diff --git a/libi2pd/Transports.cpp b/libi2pd/Transports.cpp
@@ -861,7 +861,9 @@ namespace transport
 			uint16_t inds[3];
 			RAND_bytes ((uint8_t *)inds, sizeof (inds));
 			std::unique_lock<std::mutex> l(m_PeersMutex);
-			inds[0] %= m_Peers.size ();
+			auto count = m_Peers.size ();
+			if(count == 0) return nullptr;
+			inds[0] %= count;
 			auto it = m_Peers.begin ();
 			std::advance (it, inds[0]);
 			// try random peer