Issue #27 - update router.js #32
Conversation
|
Hey there- I'm a bot, here to let you know that some code in this PR might not Please see that Pull Request's description for more details. |
| ph : req.body.ph, | ||
| }) | ||
| name, username, email, password, ph | ||
| }); |
There was a problem hiding this comment.
@mashuDuek Can you provide any relevant materials showing that the schema constructor supports this method of initialization i.e. without key-value pairs?
Because as far as the mongoose documentation and other relevant online resources go, they all seem to adhere to this key-value scheme.
Also, chances are schema constructors don't support self-resolution i.e. they need key-value pairs .
Feel free to drop any relevant resources/code
There was a problem hiding this comment.
Having a rough time finding an example that uses ES6 syntax object creation to instantiate a mongoose model.
What is passed is as an argument to new users is the same thing it was before, it shouldn't have changed functionality. MDN Object Initializer
There was a problem hiding this comment.
Was this not good enough documentation on this?
|
@Purukitto @pranjaldatta Didn't #27 say that the file must be no longer than 15 lines of code? |
Makes use of ES6 and cleans up some of the logic for
'/signin'route