Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing program portfolio #45

Merged
merged 3 commits into from
May 22, 2020
Merged

Fixing program portfolio #45

merged 3 commits into from
May 22, 2020

Conversation

Petterandre
Copy link
Contributor

@Petterandre Petterandre commented May 22, 2020

Close to identical in pp main

Your checklist for this pull request

  • Make sure you are requesting to pull a feature/bugfix/issue branch (right side).
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev branch.

Description

Added styling to div #pp-program-portfolio.

How to test

Install and build.
Note: There appears to be an issue with having a separate compiled .css file that is not main.css - pzlcloud has a program.css file, but seems not to be linked. May need to be linked before change will be viewed.

Relevant issues (if applicable)

Closes #44

Close to identical in pp main
@olemp olemp changed the title Added styling to program portfolio [Draft] Fixing program portfolio May 22, 2020
@olemp olemp self-requested a review May 22, 2020 11:02
@olemp
Copy link
Collaborator

olemp commented May 22, 2020

I get the following error when trying to build.

microsoft/TypeScript#33130

@olemp olemp self-assigned this May 22, 2020
@olemp olemp added the bug Something isn't working label May 22, 2020
@olemp olemp linked an issue May 22, 2020 that may be closed by this pull request
@olemp
Copy link
Collaborator

olemp commented May 22, 2020

@Petterandre Test now. 100vh height should be OK temp fix.

@Petterandre
Copy link
Contributor Author

Ran gulp watch. Worked like a charm

@olemp olemp marked this pull request as draft May 22, 2020 11:56
@olemp olemp changed the title [Draft] Fixing program portfolio Fixing program portfolio May 22, 2020
@olemp olemp marked this pull request as ready for review May 22, 2020 11:56
@olemp olemp merged commit 2cd1ad4 into dev May 22, 2020
@olemp olemp deleted the issue/44 branch May 22, 2020 11:57
olemp added a commit that referenced this pull request May 22, 2020
Co-authored-by: olemp <olemp@puzzlepart.com>

Co-authored-by: Petterandre <petterbraten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program portfolio overview not working
2 participants